Commit 485468f
OSS CI: emit PIC + THRIFT_SERIALIZATION_ONLY cmake defines
Summary:
The hand-maintained workflow yml in the rebalancer OSS GitHub repo passes `CMAKE_POSITION_INDEPENDENT_CODE: ON` to every dep build (boost, clang19, fmt, folly, fbthrift, …) and `THRIFT_SERIALIZATION_ONLY: ON` to fbthrift. The fbsource-side regenerated yml drops these on every regen, requiring repeated hand-fixes to keep CI green.
This change makes the regen produce the same defines:
- `update-all-github-actions.sh`: pass `--extra-cmake-defines '{"CMAKE_POSITION_INDEPENDENT_CODE":"ON"}'` and `--package-extra-cmake-defines fbthrift='{"THRIFT_SERIALIZATION_ONLY":"ON"}'` to the rebalancer linux + darwin generate-github-actions invocations.
- `getdeps.py` (`generate-github-actions`): seed the per-step `extra_cmake_defines` dict from `args.extra_cmake_defines` so the existing flag actually propagates to dep build steps. Previously the flag was registered but ignored at the generator level — the dict was always re-initialized to empty before being merged with sccache + per-package overrides. This matches the flag's documented semantics ('current project and all its deps').
Only the rebalancer GEN lines pass the new flag, so other projects' workflows are unaffected.
The README.facebook.md tweak drops the literal '`generated`' rendering since these files do not actually carry the generated marker.
Differential Revision: D103882417
fbshipit-source-id: 5cf428eb688e7c51ff600d923a73a9ddc824c27c1 parent d4c9316 commit 485468f
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1244 | 1244 | | |
1245 | 1245 | | |
1246 | 1246 | | |
1247 | | - | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
1248 | 1250 | | |
1249 | 1251 | | |
1250 | 1252 | | |
| |||
0 commit comments