Skip to content

Commit 5cb81b8

Browse files
jianfeng-tangfacebook-github-bot
authored andcommitted
fix hang issue
Summary: It happens often on BigCache origincache simulation. Let's fail fast instead of hanging there forever. Reviewed By: AhmedWKamal Differential Revision: D73675903 fbshipit-source-id: b2070d6d5026a9ddb9a81df00b3f53e597569e0c
1 parent 165c911 commit 5cb81b8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

cachelib/cachebench/cache/TimeStampTicker.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ bool TimeStampTicker::advanceTimeStamp(uint32_t currTimeStamp) {
3939
auto currentBucket = currTimeStamp / bucketTicks_;
4040

4141
if (oldBucket > currentBucket) {
42-
XLOGF(ERR, "Bucket going BACKWARD from {} to {}", oldBucket, currentBucket);
4342
// This is an indication that our time-advancing mechanism has a bug.
44-
// TODO: Once T85645217 is fixed, throw an exception.
45-
return false;
43+
// TODO: Fix T85645217.
44+
throw std::runtime_error(folly::to<std::string>(
45+
"Bucket going BACKWARD from", oldBucket, "to", currentBucket));
4646
}
4747

4848
// Bucket matches. No update required.

0 commit comments

Comments
 (0)