Skip to content

Commit 72b90c6

Browse files
IvanTopolcicmeta-codesync[bot]
authored andcommitted
Fix copy-paste bug in HitsPerSlabStrategy::exportConfig()
Summary: `exportConfig()` was reporting `config_.minSlabs` for the `num_slabs_free_mem` key instead of `config_.numSlabsFreeMem`. This meant monitoring would show the wrong value for this config field Reviewed By: AlnisM Differential Revision: D104298706 fbshipit-source-id: e7c800f31bd62ce7591d815f00f6ba1d07ac4b08
1 parent 0100830 commit 72b90c6

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

cachelib/allocator/HitsPerSlabStrategy.h

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -118,15 +118,16 @@ class HitsPerSlabStrategy : public RebalanceStrategy {
118118

119119
// Exports configuration as a string map for monitoring.
120120
std::map<std::string, std::string> exportConfig() const override {
121-
return {{"rebalancer_type", folly::sformat("{}", getTypeString())},
122-
{"min_slabs", folly::sformat("{}", config_.minSlabs)},
123-
{"num_slabs_free_mem", folly::sformat("{}", config_.minSlabs)},
124-
{"min_lru_tail_age", folly::sformat("{}", config_.minLruTailAge)},
125-
{"max_lru_tail_age", folly::sformat("{}", config_.maxLruTailAge)},
126-
{"diff_ratio", folly::sformat("{}", config_.diffRatio)},
127-
{"min_diff", folly::sformat("{}", config_.minDiff)},
128-
{"eviction_age_map",
129-
evictionAgeMapToStr(config_.classIdTargetEvictionAge.get())}};
121+
return {
122+
{"rebalancer_type", folly::sformat("{}", getTypeString())},
123+
{"min_slabs", folly::sformat("{}", config_.minSlabs)},
124+
{"num_slabs_free_mem", folly::sformat("{}", config_.numSlabsFreeMem)},
125+
{"min_lru_tail_age", folly::sformat("{}", config_.minLruTailAge)},
126+
{"max_lru_tail_age", folly::sformat("{}", config_.maxLruTailAge)},
127+
{"diff_ratio", folly::sformat("{}", config_.diffRatio)},
128+
{"min_diff", folly::sformat("{}", config_.minDiff)},
129+
{"eviction_age_map",
130+
evictionAgeMapToStr(config_.classIdTargetEvictionAge.get())}};
130131
}
131132

132133
protected:

0 commit comments

Comments
 (0)