Skip to content

Commit 84f0b13

Browse files
rlyerlymeta-codesync[bot]
authored andcommitted
Increase CTest timeout to 300s for CI stability
Summary: The CacheLib getdeps_linux GitHub Actions CI build failed due to a flaky test timeout. Test navy-test-BlockCacheTest.BlockCache.ExpiredItemDestructorCallback exceeded the 120-second CTest limit by 0.09 seconds. This is an intermittent timing issue on shared CI runners where busy-wait loops using std::this_thread::yield() get CPU-starved. Increase the global CTest per-test timeout from 120s to 300s to provide adequate headroom for CI variability. This fix was validated on GitHub Actions CI: https://github.com/facebook/CacheLib/actions/runs/24465951879 --- > Generated by [Metamate](https://fb.workplace.com/groups/metamate.feedback/) [Metamate Session](https://internalfb.com/intern/bunny?q=eggmate%20485da8dc-73ba-43dd-8cc6-e5975a0d2eb4), [Trace](https://www.internalfb.com/confucius?session_id=485da8dc-73ba-43dd-8cc6-e5975a0d2eb4&tab=Trace) ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: cachelib Differential Revision: D101006545 fbshipit-source-id: 5ec3728b4b7dbea38d49c5fbea5a600482d04644
1 parent 9605ec3 commit 84f0b13

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

cachelib/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ function (generic_add_source_test TEST_PREFIX SOURCE_FILE)
166166
TEST_PREFIX "${TEST_PREFIX}-${TEST_NAME}."
167167
TEST_LIST "test_cases")
168168
# use same timeout as folly
169-
set_tests_properties(${test_cases} PROPERTIES TIMEOUT 120)
169+
set_tests_properties(${test_cases} PROPERTIES TIMEOUT 300)
170170
endfunction()
171171

172172

0 commit comments

Comments
 (0)