Commit a0c9a5e
fbcode_builder: keep going after build errors to surface all failures
Summary:
When CMake's `--build` runs through ninja, the build stops on the first error by default. In CI that means a single broken target masks every other failure in the build, and each red run only reveals one problem at a time.
Pass `-- -k 0` to ninja so it keeps going after errors. `-k 0` means "do not stop, regardless of failure count". The exit code of the build is still nonzero when any target fails, so this is purely an information-surfacing change — successful runs are unaffected.
getdeps always configures CMake with `-G Ninja` (see `_compute_cmake_define_args` and `CMakeBootstrap`), so the underlying build tool is always ninja. ninja requires `-k` to take a value and has no `--keep-going` long form (see `kLongOptions` in `ninja.cc`).
Reviewed By: vitaut
Differential Revision: D101570020
fbshipit-source-id: 912ad27b2eb790be0f64f074f9257c71f1f5f5ae1 parent daaa4d9 commit a0c9a5e
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1008 | 1008 | | |
1009 | 1009 | | |
1010 | 1010 | | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
1011 | 1017 | | |
1012 | 1018 | | |
1013 | 1019 | | |
| |||
1047 | 1053 | | |
1048 | 1054 | | |
1049 | 1055 | | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
1050 | 1062 | | |
1051 | 1063 | | |
1052 | 1064 | | |
| |||
0 commit comments