Fix CQS signal. Id] 56922444 -- performance-unnecessary-value-param in fbcode/cachelib/navy

generatedunixname89002005287564 · facebook-github-bot · commit a9e80ebeb0f9 · 2025-05-02T18:23:31.000-07:00
Reviewed By: dtolnay

Differential Revision: D74077139

fbshipit-source-id: f08fe347961da1ac20b12a6f9c687b22dcba780f
diff --git a/cachelib/navy/Factory.cpp b/cachelib/navy/Factory.cpp
@@ -206,8 +206,8 @@ class EnginePairProtoImpl final : public EnginePairProto {
   }
 
   EnginePair create(Device* device,
-                    ExpiredCheck checkExpired,
-                    DestructorCallback destructorCb,
+                    const ExpiredCheck& checkExpired,
+                    const DestructorCallback& destructorCb,
                     JobScheduler& scheduler) {
     std::unique_ptr<Engine> bh;
 

Original file line number	Diff line number	Diff line change
`@@ -206,8 +206,8 @@ class EnginePairProtoImpl final : public EnginePairProto {`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`EnginePair create(Device* device,`
`209`		`- ExpiredCheck checkExpired,`
`210`		`- DestructorCallback destructorCb,`
	`209`	`+ const ExpiredCheck& checkExpired,`
	`210`	`+ const DestructorCallback& destructorCb,`
`211`	`211`	`JobScheduler& scheduler) {`
`212`	`212`	`std::unique_ptr<Engine> bh;`
`213`	`213`