Skip to content

Commit b4b935d

Browse files
haowu14facebook-github-bot
authored andcommitted
Part of Ubuntu22 build fix
Summary: Currently Ubuntu22 is failing due to submodule. But before that, there was a failure ``` In file included from /home/runner/work/CacheLib/CacheLib/cachelib/allocator/tests/ChainedHashTest.cpp:18: /home/runner/work/CacheLib/CacheLib/cachelib/../cachelib/allocator/tests/AccessTypeTest.h: In member function ‘void facebook::cachelib::tests::AccessTypeTest<AccessType>::testIteratorMayContainNull()’: /home/runner/work/CacheLib/CacheLib/cachelib/../cachelib/allocator/tests/AccessTypeTest.h:596:49: error: need ‘typename’ before ‘facebook::cachelib::tests::AccessTypeTest<AccessType>::Node::Handle’ because ‘facebook::cachelib::tests::AccessTypeTest<AccessType>::Node’ is a dependent scope 596 | [&keyToReturnNull](Node* node) -> Node::Handle { | ^~~~ | typename /home/runner/work/CacheLib/CacheLib/cachelib/../cachelib/allocator/tests/AccessTypeTest.h: In instantiation of ‘void facebook::cachelib::tests::AccessTypeTest<AccessType>::testIteratorMayContainNull() [with AccessType = facebook::cachelib::ChainedHashTable]’: /home/runner/work/CacheLib/CacheLib/cachelib/allocator/tests/ChainedHashTest.cpp:57:29: required from here /home/runner/work/CacheLib/CacheLib/cachelib/../cachelib/allocator/tests/AccessTypeTest.h:595:13: error: no matching function for call to ‘facebook::cach ``` This diff fixes this failure in particular. Reviewed By: therealgymmy Differential Revision: D58554675 fbshipit-source-id: ffa0c110cf5bc79f1cdf58c51b572edf5bb797be
1 parent c25161a commit b4b935d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

cachelib/allocator/tests/AccessTypeTest.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ template <typename AccessType>
593593
void AccessTypeTest<AccessType>::testIteratorMayContainNull() {
594594
std::string keyToReturnNull{};
595595
Container c{Config{}, PtrCompressor{},
596-
[&keyToReturnNull](Node* node) -> Node::Handle {
596+
[&keyToReturnNull](Node* node) -> typename Node::Handle {
597597
if (!node) {
598598
return nullptr;
599599
}

0 commit comments

Comments
 (0)