Fix duplicate REMOVE event in remove(AccessIterator)

pbhandar2 · meta-codesync[bot] · commit cf9069f1cd64 · 2026-04-20T14:44:18.000-07:00
Summary: remove(AccessIterator&amp;) records a REMOVE/REMOVED event before calling removeImpl(), but passes the default recordApiEvent=true to removeImpl(), which records the same REMOVE event again. This results in duplicate REMOVE events for a single remove-by-iterator operation. Fix by passing recordApiEvent=false to removeImpl() since the event is already recorded by the caller.

Reviewed By: rlyerly

Differential Revision: D100876318

fbshipit-source-id: 632ac377f87ad5d75843a5b70b5fbb35615ae0a7
diff --git a/cachelib/allocator/CacheAllocator.h b/cachelib/allocator/CacheAllocator.h
@@ -4247,7 +4247,8 @@ CacheAllocator<CacheTrait>::remove(AccessIterator& it) {
   HashedKey hk{it->getKey()};
   auto tombstone =
       nvmCache_ ? nvmCache_->createDeleteTombStone(hk) : DeleteTombStoneGuard{};
-  return removeImpl(hk, *it, std::move(tombstone));
+  return removeImpl(hk, *it, std::move(tombstone), true /* removeFromNvm */,
+                    false /* recordApiEvent */);
 }
 
 template <typename CacheTrait>

Original file line number	Diff line number	Diff line change
`@@ -4247,7 +4247,8 @@ CacheAllocator<CacheTrait>::remove(AccessIterator& it) {`
`4247`	`4247`	`HashedKey hk{it->getKey()};`
`4248`	`4248`	`auto tombstone =`
`4249`	`4249`	`nvmCache_ ? nvmCache_->createDeleteTombStone(hk) : DeleteTombStoneGuard{};`
`4250`		`- return removeImpl(hk, *it, std::move(tombstone));`
	`4250`	`+ return removeImpl(hk, it, std::move(tombstone), true / removeFromNvm */,`
	`4251`	`+ false /* recordApiEvent */);`
`4251`	`4252`	`}`
`4252`	`4253`
`4253`	`4254`	`template <typename CacheTrait>`