Commit f0a9d21
Fix snappy windows getdeps build failure by disabling benchmarks
Summary:
The snappy getdeps build was failing with CMake error about missing third_party/benchmark directory. This occurred after the snappy version was bumped from 1.1.7 to commit 1.2.2 in D104478389.
Root Cause:
The newer snappy version includes a third_party/benchmark git submodule (google/benchmark). When downloading from GitHub as a tarball, git submodules are not included, leaving the directory empty. The snappy CMakeLists.txt unconditionally tries to add this subdirectory at line 414, causing the build to fail.
Fix:
Add SNAPPY_BUILD_BENCHMARKS = OFF to the cmake.defines section in the snappy manifest. This prevents CMake from trying to add the missing benchmark subdirectory, similar to how SNAPPY_BUILD_TESTS = OFF is already used.
Reviewed By: sandarsh
Differential Revision: D105247037
fbshipit-source-id: a1a290f1fb13a1f7545aa43be673b0206435ec431 parent bf833c8 commit f0a9d21
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
0 commit comments