Skip to content

Commit f0a9d21

Browse files
jbeshaymeta-codesync[bot]
authored andcommitted
Fix snappy windows getdeps build failure by disabling benchmarks
Summary: The snappy getdeps build was failing with CMake error about missing third_party/benchmark directory. This occurred after the snappy version was bumped from 1.1.7 to commit 1.2.2 in D104478389. Root Cause: The newer snappy version includes a third_party/benchmark git submodule (google/benchmark). When downloading from GitHub as a tarball, git submodules are not included, leaving the directory empty. The snappy CMakeLists.txt unconditionally tries to add this subdirectory at line 414, causing the build to fail. Fix: Add SNAPPY_BUILD_BENCHMARKS = OFF to the cmake.defines section in the snappy manifest. This prevents CMake from trying to add the missing benchmark subdirectory, similar to how SNAPPY_BUILD_TESTS = OFF is already used. Reviewed By: sandarsh Differential Revision: D105247037 fbshipit-source-id: a1a290f1fb13a1f7545aa43be673b0206435ec43
1 parent bf833c8 commit f0a9d21

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • build/fbcode_builder/manifests

build/fbcode_builder/manifests/snappy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ subdir = snappy-27ab5f7f518430a021239bc26a5b2fd64affbc7b
2323

2424
[cmake.defines]
2525
SNAPPY_BUILD_TESTS = OFF
26+
SNAPPY_BUILD_BENCHMARKS = OFF
2627

2728
# Avoid problems like `relocation R_X86_64_PC32 against symbol` on ELF systems
2829
# when linking rocksdb, which builds PIC even when building a static lib

0 commit comments

Comments
 (0)