Skip to content

Commit dfcebf4

Browse files
Jiaming Youmeta-codesync[bot]
authored andcommitted
Disabled getNormalizedAndHashedPII and getClientIpAddress for GTM
Summary: Disabled getNormalizedAndHashedPII and getClientIpAddress for GTM Reviewed By: hongj-src Differential Revision: D84180181 fbshipit-source-id: fb3c05f59e069df85608490ba07166db8181e67c
1 parent 82628a7 commit dfcebf4

2 files changed

Lines changed: 6 additions & 14 deletions

File tree

php/capi-param-builder/src/ParamBuilder.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,15 +274,16 @@ public function getFbp()
274274
return $this->fbp;
275275
}
276276

277-
public function getClientIpAddress()
277+
// make public once GTM
278+
private function getClientIpAddress()
278279
{
279280
return $this->fbi;
280281
}
281282

282-
public function getNormalizedAndHashedPII($piiValue, $dataType)
283+
// make public once GTM
284+
private function getNormalizedAndHashedPII($piiValue, $dataType)
283285
{
284-
return null;
285-
//return PIIUtils::getNormalizedAndHashedPII($piiValue, $dataType);
286+
return PIIUtils::getNormalizedAndHashedPII($piiValue, $dataType);
286287
}
287288

288289
// TODO: this needs optimizatino, maybe use a DAFSA format,

php/examples/local/FacebookParamManager.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,18 +69,9 @@ public function processThisRequest()
6969
}
7070
}
7171

72-
$normalized_and_hashed_pii =
73-
$this->paramBuilder->getNormalizedAndHashedPII(
74-
' John_Smith@gmail.com ',
75-
'email'
76-
);
77-
7872
echo 'ParamBuilder output: <br/>'
7973
. 'getFbc: ' . $this->paramBuilder->getFbc() . '<br/>'
80-
. 'getFbp: ' . $this->paramBuilder->getFbp() . '<br/>'
81-
. 'getClientIpAddress: ' . $this->paramBuilder->getClientIpAddress() . '<br/>'
82-
. 'getNormalizedAndHashedPII: '
83-
. $normalized_and_hashed_pii . '<br/>';
74+
. 'getFbp: ' . $this->paramBuilder->getFbp() . '<br/>';
8475
}
8576

8677

0 commit comments

Comments
 (0)