Commit f334b26
Bump Client JS SDK to v1.3.1 to publish umdNamedDefine fix
Summary:
The `umdNamedDefine: true` webpack fix (D105386494) landed and was tagged as GitHub release v1.3.1, but the npm package was never bumped past 1.3.0. As a result, the bundle served via unpkg (https://unpkg.com/meta-capi-param-builder-clientjs/dist/clientParamBuilder.bundle.js) still ships the old 1.3.0 build with the anonymous `define([], t)`, so consumers pulling from npm/unpkg never received the fix. This was reported in #32.
This diff bumps `package.json` from 1.3.0 to 1.3.1, adds a v1.3.1 CHANGELOG entry, and updates the stale Client JS row in the top-level README version table (was 1.2.2). The webpack `DefinePlugin` injects the version from `package.json` into the bundle, so the version must be bumped for a fresh build to embed 1.3.1.
Release context (per the CAPI param builder CI/CD cook book): the Client JS SDK is published to npm only when a `vx.x.x-clientjs` git tag is pushed to the public GitHub repo, which triggers a GitHub Actions CD workflow (Trusted Publishers / OIDC — no auth token needed). The tagged GitHub commit must already contain `package.json` at 1.3.1, and `client_js` only reaches GitHub via ShipIt after this diff lands. Therefore this diff must land first; ShipIt then async-syncs it to GitHub; only then can the release tag be pushed. The supported-version prerequisite (`CAPIParamBuilderSupportedVersionUtil.php` must contain the new version for metrics) is already satisfied — `V1_3_1 = 'v1.3.1'` is present in the enum.
After this lands and the npm publish runs, unpkg will serve the bundle containing the named `define('clientParamBuilder', [], t)`, resolving the RequireJS / Magento 2 checkout conflict for npm/unpkg consumers.
Reviewed By: jyou23github
Differential Revision: D107943908
fbshipit-source-id: 79e92b4a669808abe23ef9be7c399b8183af15ba1 parent cd781a0 commit f334b26
3 files changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
7 | 10 | | |
8 | 11 | | |
9 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments