Fix Thrift union __type property bounds check in spec-holder#9742
Open
cuiweixie wants to merge 1 commit into
Open
Fix Thrift union __type property bounds check in spec-holder#9742cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
When the number of declared properties equals the TSPEC field count, the extra __type slot at declProperties()[spec.size()] does not exist. Use <= instead of < so we do not read past the end of declProperties().
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D98601431. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an off-by-one in
compileSpecwhen validating the extra__typeproperty for Thrift unions.When
numDeclProperties()equalsspec.size(), there is no property atdeclProperties()[spec.size()](indices are0 .. numDeclProperties()-1). The previous check used<, which allowed that case and could read past the end ofdeclProperties().Test plan