Skip to content

Quality: Fix recursive directory traversal to properly find all files #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andoan16 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Quality: Fix recursive directory traversal to properly find all files #697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,13 @@ function dirFiles (dir, callback, acc) {
// (this should not happen as long as calls do the necessary checks)
if (err) throw err;

if (files.length === 0) {
done();
return;
}

acc.remaining += files.length;
done();
files.forEach(file => {
let name = path.join(dir, file);
fs.stat(name, (err, stats) => {
Expand All @@ -131,7 +137,6 @@ function dirFiles (dir, callback, acc) {
}
});
});
done();
});
}

Expand Down