Fix: Add support for relative Platform ES imports (inline-plugin)#1692
Open
retyui wants to merge 1 commit into
Open
Fix: Add support for relative Platform ES imports (inline-plugin)#1692retyui wants to merge 1 commit into
retyui wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
retyui
force-pushed
the
fix/retyui/inline-plugin-relative-imports
branch
from
8658437 to
6b2e449
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
retyui
force-pushed
the
fix/retyui/inline-plugin-relative-imports
branch
from
6b2e449 to
069af3d
Compare
Contributor
Author
|
@robhogan could you please review this PR ? |
Contributor
|
Stop spamming me, @retyui, please. |
Contributor
Author
|
Oops, sorry Rob for the notifications! I'll ease up. Hope you're having a good day otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read: #1521 (comment) and this facebook/react-native#56344
Changelog: [Fix] Metro inline plugin doesn't work with a relative ES import of
PlatformTest plan
Also React Native build:
Before
After: