Convert arvr mode constraint to a constraint() rule

Summary:
X-link: pytorch/executorch#18818

#force_dangling_check

Converting the arvr mode constraint to a constraint().

Reviewed By: rexzhang123

Differential Revision: D99903392

fbshipit-source-id: 090d534b9b57a3e40ac52963a530150a4e9054e0

Author: 8Keep

quic/BUCK

@@ -26,7 +26,7 @@ mvfst_cpp_library(
             "DEFAULT": {
                 "QuicEnum.h": "facebook/QuicEnumMobile.h",
             },
-            "ovr_config//build_mode/constraints:arvr_mode_enabled": {
+            "ovr_config//build_mode:arvr_mode[enabled]": {
                 "QuicEnum.h": "QuicEnum.h",
             },
         }),
@@ -41,7 +41,7 @@ mvfst_cpp_library(
         ],
         "ovr_config//os/constraints:android": select({
             "DEFAULT": [],
-            "ovr_config//build_mode/constraints:arvr_mode_enabled": [
+            "ovr_config//build_mode:arvr_mode[enabled]": [
                 "//folly/lang:assume",
                 "//quic/common/third-party:better_enums",
             ],
@@ -63,7 +63,7 @@ mvfst_cpp_library(
         "ovr_config//runtime/constraints:fbcode": select({
             "DEFAULT": {"mvfst-config.h": "facebook/mvfst-config-fbcode.h"},  # @fb-only
             "fbcode//quic:use_alt_crypto-enabled": {"mvfst-config.h": "facebook/mvfst-config-alt-crypto.h"},  # @fb-only
-            "ovr_config//build_mode:arvr_mode": select({
+            "ovr_config//build_mode:arvr_mode[enabled]": select({
                 "DEFAULT": {"mvfst-config.h": "mvfst-config.h"},  # @fb-only
                 "ovr_config//os/constraints:android": {"mvfst-config.h": "facebook/mvfst-config-mobile.h"},  # @fb-only
                 "ovr_config//os/constraints:iphoneos": {"mvfst-config.h": "facebook/mvfst-config-mobile.h"},  # @fb-only
@@ -154,7 +154,7 @@ mvfst_cpp_library(
         "DEFAULT": ["QuicTLSExceptionFizz.cpp"],
         "ovr_config//os/constraints:android": select({
             "DEFAULT": ["facebook/mbed/QuicTLSExceptionMbed.cpp"],  # @fb-only
-            "ovr_config//build_mode/constraints:arvr_mode_enabled": ["QuicTLSExceptionFizz.cpp"],
+            "ovr_config//build_mode:arvr_mode[enabled]": ["QuicTLSExceptionFizz.cpp"],
         }),
         "ovr_config//os/constraints:iphoneos": ["facebook/mbed/QuicTLSExceptionMbed.cpp"],  # @fb-only
     }),
@@ -169,7 +169,7 @@ mvfst_cpp_library(
             "DEFAULT": [
                 "fbsource//xplat/mobilenetwork:tls_common",  # @manual
             ],
-            "ovr_config//build_mode/constraints:arvr_mode_enabled": [
+            "ovr_config//build_mode:arvr_mode[enabled]": [
                 "//fizz/record:record",
             ],
         }),

quic/defs.bzl

@@ -121,7 +121,7 @@ def mvfst_cxx_library(
             "DEFAULT": force_static,
             "ovr_config//runtime:fbcode": False,
         }),
-        "ovr_config//build_mode:arvr_mode": force_static,
+        "ovr_config//build_mode:arvr_mode[enabled]": force_static,
     })
 
     fb_xplat_cxx_library(
@@ -302,7 +302,7 @@ def mu_cxx_library(
             "DEFAULT": force_static,
             "ovr_config//runtime:fbcode": False,
         }),
-        "ovr_config//build_mode:arvr_mode": force_static,
+        "ovr_config//build_mode:arvr_mode[enabled]": force_static,
     })
 
     fb_xplat_cxx_library(

quic/fizz/handshake/BUCK

@@ -67,7 +67,7 @@ mvfst_cpp_library(
         "ovr_config//runtime/constraints:fbcode": select({
             "DEFAULT": [],  # @fb-only
             "fbcode//quic:use_alt_crypto-enabled": ["fbcode//quic/facebook/handshake:xsec_crypto_bridge"],  # @fb-only
-            "ovr_config//build_mode:arvr_mode": [],  # @fb-only
+            "ovr_config//build_mode:arvr_mode[enabled]": [],  # @fb-only
             "ovr_config//runtime/constraints:android-host-test": [],  # @fb-only
         }),  # @fb-only
     }),

quic/state/BUCK

@@ -235,7 +235,7 @@ mvfst_cpp_library(
         # ARVR Android uses full stats callback
         "ovr_config//os/constraints:android": select({
             "DEFAULT": {"QuicTransportStatsCallback.h": "facebook/QuicTransportStatsCallbackMobile.h"},
-            "ovr_config//build_mode/constraints:arvr_mode_enabled": {"QuicTransportStatsCallback.h": "QuicTransportStatsCallback.h"},
+            "ovr_config//build_mode:arvr_mode[enabled]": {"QuicTransportStatsCallback.h": "QuicTransportStatsCallback.h"},
         }),
         "ovr_config//os/constraints:iphoneos": {"QuicTransportStatsCallback.h": "facebook/QuicTransportStatsCallbackMobile.h"},
     }),
@@ -252,7 +252,7 @@ mvfst_cpp_library(
                 "//quic:exception",
                 "//quic/common:optional",
             ],
-            "ovr_config//build_mode/constraints:arvr_mode_enabled": [
+            "ovr_config//build_mode:arvr_mode[enabled]": [
                 "//folly/functional:invoke",
                 "//quic:constants",
                 "//quic:exception",