This repository was archived by the owner on Jun 26, 2026. It is now read-only.
Integration test for node false negative pattern #895
Open
esohel30 wants to merge 4 commits into
Open
Conversation
tianhan0
suggested changes
Jul 10, 2024
tianhan0
left a comment
There was a problem hiding this comment.
Thanks for adding the test!
Could you also include the expected results for this test (e.g., the *.models files)? Otherwise the CI tests would fail.
You can run Pysa on all integration tests by executing OUNIT_SHARDS=1 dune exec interprocedural_analyses/taint/test/integrationTest.exe under pyre/source. This would
- either create new expected results for new tests (such as this PR), because there is no existing expected results.
- or create the actual results, when they differ from the existing expected results.
Additionally, could we
- rename this test to be more descriptive, such as
heap_alias.py? We try to let the name of each integration test be as descriptive as possible. - add a few comments in the .py file to explain why this is a false negative. You could paraphrase Maxime's explanation (in the chat).
Contributor
|
cc @tianhan0 for updated review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding integration test for node false negative pattern.