Fix some clippy issues on main (#731)

Summary:
Ran `cargo clippy --fix` and also applied fixes manually for preferring `matches!` macros

Pull Request resolved: #731

Reviewed By: stroxler

Differential Revision: D78774596

Pulled By: migeed-z

fbshipit-source-id: ec4e1507423cd5725379664dcbe65e35044d1540

Author: fangyi-zhou

crates/pyrefly_config/src/config.rs

@@ -67,7 +67,7 @@ pub enum ConfigSource {
 }
 
 impl ConfigSource {
-    pub fn root<'a>(&'a self) -> Option<&'a Path> {
+    pub fn root(&self) -> Option<&Path> {
         match &self {
             Self::File(path) | Self::Marker(path) => path.parent(),
             Self::Synthetic => None,
@@ -387,14 +387,14 @@ impl ConfigFile {
         self.python_environment.python_platform.as_ref().unwrap()
     }
 
-    pub fn search_path<'a>(&'a self) -> impl Iterator<Item = &'a PathBuf> + Clone {
+    pub fn search_path(&self) -> impl Iterator<Item = &PathBuf> + Clone {
         self.search_path_from_args
             .iter()
             .chain(self.search_path_from_file.iter())
             .chain(self.import_root.iter())
     }
 
-    pub fn site_package_path<'a>(&'a self) -> impl Iterator<Item = &'a PathBuf> + Clone {
+    pub fn site_package_path(&self) -> impl Iterator<Item = &PathBuf> + Clone {
         // we can use unwrap here, because the value in the root config must
         // be set in `ConfigFile::configure()`.
         self.python_environment

crates/pyrefly_config/src/migration/pyright.rs

@@ -119,10 +119,7 @@ pub enum DiagnosticLevel {
 
 impl DiagnosticLevel {
     fn to_bool(&self) -> bool {
-        match self {
-            Self::None => false,
-            _ => true,
-        }
+        !matches!(self, Self::None)
     }
 }
 

crates/pyrefly_config/src/util.rs

@@ -142,10 +142,7 @@ impl<T> ConfigOrigin<T> {
     /// We only serialize if the value is `Some(ConfigFile)`. All other
     /// [`Option`] and [`ConfigOrigin`] variants are not serialized.
     pub(crate) fn should_skip_serializing_option(origin: &Option<Self>) -> bool {
-        match origin {
-            Some(Self::ConfigFile(_)) => false,
-            _ => true,
-        }
+        !matches!(origin, Some(Self::ConfigFile(_)))
     }
 }
 

pyrefly/bin/main.rs

@@ -58,7 +58,7 @@ async fn main() -> ExitCode {
         Err(e) => {
             // If you return a Result from main, and RUST_BACKTRACE=1 is set, then
             // it will print a backtrace - which is not what we want.
-            eprintln!("{:#}", e);
+            eprintln!("{e:#}");
             ExitCode::FAILURE
         }
     }