Drop the unused incomplete_attributes from pyrefly coverage#4031
Closed
jorenham wants to merge 1 commit into
Closed
Drop the unused incomplete_attributes from pyrefly coverage#4031jorenham wants to merge 1 commit into
incomplete_attributes from pyrefly coverage#4031jorenham wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
@grievejia has imported this pull request. If you are a Meta employee, you can view this in D111096477. |
stroxler
approved these changes
Jul 9, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
Author
|
rebased onto main and resolved the merge conflict |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@grievejia merged this pull request in 442d4c9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_classesno longer fillsReportClass.incomplete_attributesby walking each class's MRO, sincebuild_module_reportdropped it anyway.Fixes #4023
Test Plan
Tests still pass; no behavior changes