detect slots layout conflict in multiple inheritance#3011
Closed
knQzx wants to merge 2 commits intofacebook:mainfrom
Closed
detect slots layout conflict in multiple inheritance#3011knQzx wants to merge 2 commits intofacebook:mainfrom
knQzx wants to merge 2 commits intofacebook:mainfrom
Conversation
when two or more base classes define non-empty __slots__, cpython raises a TypeError at runtime. this adds a check for that during class metadata computation and flags it as an InvalidInheritance error. fixes facebook#2916 and facebook#2917
stroxler
approved these changes
Apr 6, 2026
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
LGTM, I'll try to get it merged this week. Thanks for the contribution!
Contributor
yangdanny97
approved these changes
Apr 7, 2026
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
__slots__, which causes a TypeError at runtime in cpythonbugmarkers from the existing test cases for __slots__ layout conflict with same slot names #2916 and __slots__ layout conflict in multiple inheritance #2917 and added expected error commentstest plan
cargo test -p pyrefly -- test_slots- all 27 tests passfixes #2916
fixes #2917