Softens unused import diagnostic to "may be unused" instead of "is un…#4056
Open
kz357 wants to merge 1 commit into
Open
Softens unused import diagnostic to "may be unused" instead of "is un…#4056kz357 wants to merge 1 commit into
kz357 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
yangdanny97
reviewed
Jul 6, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Can you update the docs as well? after that this should be good to merge
…used", per facebook#3949 Fixes facebook#3949 Documentation for IDE-only unused-import hint added to IDE-features.mdx Avoided error-kinds.mdx because it's only an IDE hint
kz357
force-pushed
the
fix/issue-3949-soften-unused-import
branch
from
e8862d9 to
fbefb5d
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Softens unused-import diagnostic from "is unused" to "may be unused", per #3949 comments
Added documentation to website/docs/IDE-features.mdx under [Diagnostics]
Fixes #3949
Test Plan
Changed unused-import tests in pyrefly/lib/test/lsp/diagnostic.rs and pyrefly/lib/test/lsp/lsp_interaction/diagnostic.rs to check for "may be unused"