Skip to content

Commit 1d9ec33

Browse files
authored
Merge branch 'main' into feature-host-lifecycle-correctness
2 parents 82b0310 + d8824de commit 1d9ec33

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

front_end/core/host/RNPerfMetrics.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@ class RNPerfMetrics {
216216
}
217217
}
218218

219+
traceRequested(): void {
220+
this.sendEvent({eventName: 'Tracing.TraceRequested'});
221+
}
222+
219223
heapSnapshotStarted(): void {
220224
this.sendEvent({
221225
eventName: 'MemoryPanelActionStarted',
@@ -539,12 +543,17 @@ export type ManualBreakpointSetSucceeded = Readonly<{
539543
}>,
540544
}>;
541545

546+
export type TracingTraceRequestedEvent = Readonly<{
547+
eventName: 'Tracing.TraceRequested',
548+
}>;
549+
542550
export type ReactNativeChromeDevToolsEvent =
543551
EntrypointLoadingStartedEvent|EntrypointLoadingFinishedEvent|DebuggerReadyEvent|BrowserVisibilityChangeEvent|
544552
BrowserErrorEvent|RemoteDebuggingTerminatedEvent|DeveloperResourcesStartupLoadingFinishedEvent|
545553
DeveloperResourceLoadingStartedEvent|DeveloperResourceLoadingFinishedEvent|FuseboxSetClientMetadataStartedEvent|
546-
FuseboxSetClientMetadataFinishedEvent|MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|PanelShownEvent|
547-
PanelClosedEvent|StackTraceSymbolicationSucceeded|StackTraceSymbolicationFailed|StackTraceFrameUrlResolutionSucceeded|
548-
StackTraceFrameUrlResolutionFailed|ManualBreakpointSetSucceeded|StackTraceFrameClicked;
554+
FuseboxSetClientMetadataFinishedEvent|TracingTraceRequestedEvent|MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|
555+
PanelShownEvent|PanelClosedEvent|StackTraceSymbolicationSucceeded|StackTraceSymbolicationFailed|
556+
StackTraceFrameUrlResolutionSucceeded|StackTraceFrameUrlResolutionFailed|ManualBreakpointSetSucceeded|
557+
StackTraceFrameClicked;
549558

550559
export type DecoratedReactNativeChromeDevToolsEvent = CommonEventFields&ReactNativeChromeDevToolsEvent;

front_end/core/sdk/ReactNativeApplicationModel.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export class ReactNativeApplicationModel extends SDKModel<EventTypes> implements
5757
}
5858

5959
traceRequested(): void {
60+
Host.rnPerfMetrics.traceRequested();
6061
this.dispatchEventToListeners(Events.TRACE_REQUESTED);
6162
}
6263
}

0 commit comments

Comments
 (0)