You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: README.md
+7-3Lines changed: 7 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -74,11 +74,15 @@ git tag --merged <branch>
74
74
git merge chromedevtools/chromium/5845
75
75
```
76
76
77
-
3. Submit and merge your PR.
78
-
4. Tag the merge commit! This marks the point at which we synced the repo with the upstream branch.
79
-
77
+
3. Validate your changes by running a smoke test.
78
+
You can use the one defined in the [summary of this pull request](https://github.com/facebook/react-native-devtools-frontend/pull/172), please also enhance it with more test cases and add all them to the summary of your PR.
79
+
4. Before merging your PR, go to [repository settings](https://github.com/facebook/react-native-devtools-frontend/settings) and make sure "Allow merge commits" is enabled.
80
+
5. Merge your commit. It is important to merge and not to squash, otherwise our fork would diverge from Google's upstream significantly.
81
+
6. Go to [repository settings](https://github.com/facebook/react-native-devtools-frontend/settings) and disable "Allow merge commits" setting. All changes that are not related to fork syncing should be squashed in a single commit.
82
+
7. Tag the merge commit! This marks the point at which we synced the repo with the upstream branch.
0 commit comments