Clean up legacy rn_inspector entry point (#236)

huntie · web-flow · commit 8edd9be3b89d · 2026-02-23T17:34:33.000Z
diff --git a/README.md b/README.md
@@ -48,7 +48,7 @@ This can then be served from a static web server to test locally:
 python3 -m http.server 8000 --directory out/Default/gen/front_end
 ```
 
-The frontend will be available at `http://localhost:8000/inspector.html` (or `http://localhost:8000/rn_inspector.html` for the RN-specific entry point).
+The frontend will be available at `http://localhost:8000/inspector.html` (or `http://localhost:8000/rn_fusebox.html` for the RN-specific entry point).
 
 ### Syncing with the upstream repo
 
diff --git a/config/gni/devtools_grd_files.gni b/config/gni/devtools_grd_files.gni
@@ -374,7 +374,6 @@ grd_files_release_sources = [
   "front_end/entrypoints/node_app/node_app.js",
   "front_end/entrypoints/rehydrated_devtools_app/rehydrated_devtools_app.js",
   "front_end/entrypoints/rn_fusebox/rn_fusebox.js",
-  "front_end/entrypoints/rn_inspector/rn_inspector.js",
   "front_end/entrypoints/shell/shell.js",
   "front_end/entrypoints/wasmparser_worker/wasmparser_worker-entrypoint.js",
   "front_end/entrypoints/wasmparser_worker/wasmparser_worker.js",
@@ -681,7 +680,6 @@ grd_files_release_sources = [
   "front_end/panels/recorder/recorder-meta.js",
   "front_end/panels/recorder/recorder.js",
   "front_end/panels/recorder/util/util.js",
-  "front_end/panels/rn_welcome/rn_welcome-legacy-meta.js",
   "front_end/panels/rn_welcome/rn_welcome-meta.js",
   "front_end/panels/rn_welcome/rn_welcome.js",
   "front_end/panels/screencast/screencast-meta.js",
@@ -721,7 +719,6 @@ grd_files_release_sources = [
   "front_end/panels/whats_new/whats_new.js",
   "front_end/rehydrated_devtools_app.html",
   "front_end/rn_fusebox.html",
-  "front_end/rn_inspector.html",
   "front_end/services/puppeteer/puppeteer.js",
   "front_end/services/trace_bounds/trace_bounds.js",
   "front_end/services/tracing/tracing.js",
diff --git a/front_end/BUILD.gn b/front_end/BUILD.gn
@@ -28,7 +28,6 @@ group("front_end") {
     "entrypoints/node_app:entrypoint",
     "entrypoints/rehydrated_devtools_app:entrypoint",
     "entrypoints/rn_fusebox:entrypoint",
-    "entrypoints/rn_inspector:entrypoint",
     "entrypoints/shell",
     "entrypoints/wasmparser_worker:worker_entrypoint",
     "entrypoints/worker_app:entrypoint",
@@ -78,7 +77,6 @@ node_action("html_entrypoints") {
     "ndb_app",
     "node_app",
     "rn_fusebox",
-    "rn_inspector",
     "rehydrated_devtools_app",
     "worker_app",
     "device_mode_emulation_frame",
diff --git a/front_end/core/host/RNPerfMetrics.ts b/front_end/core/host/RNPerfMetrics.ts
@@ -25,7 +25,7 @@ class RNPerfMetrics {
   #listeners = new Set<RNReliabilityEventListener>();
   #launchId: string|null = null;
   #appId: string|null = null;
-  #entryPoint: EntryPoint = 'rn_inspector';
+  #entryPoint: EntryPoint = 'rn_fusebox';
   #telemetryInfo: Object = {};
   // map of panel location to panel name
   #currentPanels = new Map<PanelLocation, string>();
@@ -381,7 +381,7 @@ function maybeWrapError(baseMessage: string, error: unknown): [string, Error] {
   return [message, new Error(message, {cause: error})];
 }
 
-type EntryPoint = 'rn_fusebox'|'rn_inspector';
+type EntryPoint = 'rn_fusebox';
 
 type CommonEventFields = Readonly<{
   timestamp: DOMHighResTimeStamp,
diff --git a/front_end/core/rn_experiments/BUILD.gn b/front_end/core/rn_experiments/BUILD.gn
@@ -25,7 +25,6 @@ devtools_entrypoint("bundle") {
 
   visibility = [
     "../../entrypoints/rn_fusebox:*",
-    "../../entrypoints/rn_inspector:*",
     "../../entrypoints/main:*",
   ]
 }
diff --git a/front_end/core/rn_experiments/experimentsImpl.ts b/front_end/core/rn_experiments/experimentsImpl.ts
@@ -24,8 +24,8 @@
 // - define it in the RNExperiments enum and Experiments enum (in Runtime.ts)
 // - register it in this file (rn_experiments.ts)
 //   - set `enabledByDefault` as appropriate
-// - optionally, configure it further in each RN-specific entry point
-//   (rn_inspector.ts, rn_fusebox.ts)
+// - optionally, configure it further in the RN-specific entry point
+//   (rn_fusebox.ts)
 //
 // React Native-specific experiments are merged into the main ExperimentsSupport
 // object in MainImpl and can't be configured further afterwards (except
diff --git a/front_end/entrypoints/inspector_main/BUILD.gn b/front_end/entrypoints/inspector_main/BUILD.gn
@@ -71,7 +71,6 @@ devtools_entrypoint("meta") {
     "../devtools_app/*",
     "../rehydrated_devtools_app/*",
     "../rn_fusebox:*",
-    "../rn_inspector:*",
   ]
 }
 
diff --git a/front_end/entrypoints/main/BUILD.gn b/front_end/entrypoints/main/BUILD.gn
@@ -57,7 +57,6 @@ devtools_entrypoint("bundle") {
     "../node_app:*",
     "../rehydrated_devtools_app:*",
     "../rn_fusebox:*",
-    "../rn_inspector:*",
     "../worker_app:*",
   ]
 
diff --git a/front_end/entrypoints/rn_inspector/BUILD.gn b/front_end/entrypoints/rn_inspector/BUILD.gn
diff --git a/front_end/entrypoints/rn_inspector/README.md b/front_end/entrypoints/rn_inspector/README.md
diff --git a/front_end/entrypoints/rn_inspector/rn_inspector.ts b/front_end/entrypoints/rn_inspector/rn_inspector.ts
diff --git a/front_end/entrypoints/shell/BUILD.gn b/front_end/entrypoints/shell/BUILD.gn
@@ -47,7 +47,6 @@ devtools_entrypoint("shell") {
     "../ndb_app:*",
     "../node_app:*",
     "../rn_fusebox:*",
-    "../rn_inspector:*",
     "../worker_app:*",
   ]
 
diff --git a/front_end/index.html b/front_end/index.html
@@ -16,9 +16,6 @@
 </style>
 <body>
   <ul>
-    <li>
-      <a href="rn_inspector.html">rn_inspector.html ⚛️</a>
-    </li>
     <li>
       <a href="rn_fusebox.html">rn_fusebox.html ⚛️</a>
     </li>
diff --git a/front_end/panels/recorder/BUILD.gn b/front_end/panels/recorder/BUILD.gn
@@ -73,7 +73,6 @@ devtools_entrypoint("meta") {
     "../../entrypoints/devtools_app:*",
     "../../entrypoints/inspector:*",
     "../../entrypoints/rn_fusebox:*",
-    "../../entrypoints/rn_inspector:*",
   ]
 }
 
diff --git a/front_end/panels/rn_welcome/BUILD.gn b/front_end/panels/rn_welcome/BUILD.gn
@@ -46,14 +46,6 @@ devtools_entrypoint("bundle") {
   visibility += devtools_panels_visibility
 }
 
-devtools_entrypoint("meta-legacy") {
-  entrypoint = "rn_welcome-legacy-meta.ts"
-
-  deps = [ ":bundle" ]
-
-  visibility = [ "../../entrypoints/rn_inspector/*" ]
-}
-
 devtools_entrypoint("meta") {
   entrypoint = "rn_welcome-meta.ts"
 
diff --git a/front_end/panels/rn_welcome/RNWelcome.ts b/front_end/panels/rn_welcome/RNWelcome.ts
@@ -16,10 +16,6 @@ import {html, render} from '../../ui/lit/lit.js';
 import rnWelcomeStyles from './rnWelcome.css.js';
 
 const UIStrings = {
-  /** @description Beta label */
-  betaLabel: 'Beta',
-  /** @description Tech Preview label */
-  techPreviewLabel: 'Tech Preview',
   /** @description Welcome text */
   welcomeMessage: 'Welcome to debugging in React Native',
   /** @description "Debugging docs" link */
@@ -49,8 +45,6 @@ let rnWelcomeImplInstance: RNWelcomeImpl;
 
 interface RNWelcomeOptions {
   debuggerBrandName: () => Platform.UIString.LocalizedString;
-  showBetaLabel?: boolean;
-  showTechPreviewLabel?: boolean;
   showDocs?: boolean;
 }
 
@@ -119,8 +113,6 @@ export class RNWelcomeImpl extends UI.Widget.VBox implements
   render(): void {
     const {
       debuggerBrandName,
-      showBetaLabel = false,
-      showTechPreviewLabel = false,
       showDocs = false,
     } = this.options;
     const welcomeIconUrl = new URL(
@@ -150,16 +142,6 @@ export class RNWelcomeImpl extends UI.Widget.VBox implements
             <h1 class="rn-welcome-title">
               ${debuggerBrandName()}
             </h1>
-            ${showBetaLabel ? html`
-              <div class="rn-welcome-title-accessory">
-                ${i18nString(UIStrings.betaLabel)}
-              </div>
-            ` : null}
-            ${showTechPreviewLabel ? html`
-              <div class="rn-welcome-title-accessory rn-welcome-title-accessory-purple">
-                ${i18nString(UIStrings.techPreviewLabel)}
-              </div>
-            ` : null}
           </div>
           <div class="rn-welcome-tagline">
             ${i18nString(UIStrings.welcomeMessage)}
diff --git a/front_end/panels/rn_welcome/rnWelcome.css b/front_end/panels/rn_welcome/rnWelcome.css
@@ -62,19 +62,6 @@
   color: var(--color-text-primary);
 }
 
-.rn-welcome-title-accessory {
-  margin-left: 12px;
-  padding: 4px 8px;
-  border-radius: 6px;
-  background-color: var(--sys-color-green-bright);
-  font-size: 12px;
-  color: var(--sys-color-primary);
-}
-
-.rn-welcome-title-accessory-purple {
-  background-color: var(--sys-color-purple-bright);
-}
-
 .rn-welcome-tagline {
   margin-bottom: 24px;
   font-size: 1rem;
diff --git a/front_end/panels/rn_welcome/rn_welcome-legacy-meta.ts b/front_end/panels/rn_welcome/rn_welcome-legacy-meta.ts
diff --git a/front_end/panels/rn_welcome/rn_welcome-meta.ts b/front_end/panels/rn_welcome/rn_welcome-meta.ts
diff --git a/scripts/build/generate_html_entrypoint.js b/scripts/build/generate_html_entrypoint.js
diff --git a/scripts/eslint_rules/lib/check-license-header.js b/scripts/eslint_rules/lib/check-license-header.js

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ devtools_entrypoint("bundle") {`
`25`	`25`
`26`	`26`	`visibility = [`
`27`	`27`	`"../../entrypoints/rn_fusebox:*",`
`28`		`- "../../entrypoints/rn_inspector:*",`
`29`	`28`	`"../../entrypoints/main:*",`
`30`	`29`	`]`
`31`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,6 @@ devtools_entrypoint("meta") {`
`71`	`71`	`"../devtools_app/*",`
`72`	`72`	`"../rehydrated_devtools_app/*",`
`73`	`73`	`"../rn_fusebox:*",`
`74`		`- "../rn_inspector:*",`
`75`	`74`	`]`
`76`	`75`	`}`
`77`	`76`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,6 @@ devtools_entrypoint("bundle") {`
`57`	`57`	`"../node_app:*",`
`58`	`58`	`"../rehydrated_devtools_app:*",`
`59`	`59`	`"../rn_fusebox:*",`
`60`		`- "../rn_inspector:*",`
`61`	`60`	`"../worker_app:*",`
`62`	`61`	`]`
`63`	`62`