Skip to content

Commit 8edd9be

Browse files
authored
Clean up legacy rn_inspector entry point (#236)
1 parent 1de9f99 commit 8edd9be

File tree

21 files changed

+5
-242
lines changed

21 files changed

+5
-242
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ This can then be served from a static web server to test locally:
4848
python3 -m http.server 8000 --directory out/Default/gen/front_end
4949
```
5050

51-
The frontend will be available at `http://localhost:8000/inspector.html` (or `http://localhost:8000/rn_inspector.html` for the RN-specific entry point).
51+
The frontend will be available at `http://localhost:8000/inspector.html` (or `http://localhost:8000/rn_fusebox.html` for the RN-specific entry point).
5252

5353
### Syncing with the upstream repo
5454

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,6 @@ grd_files_release_sources = [
374374
"front_end/entrypoints/node_app/node_app.js",
375375
"front_end/entrypoints/rehydrated_devtools_app/rehydrated_devtools_app.js",
376376
"front_end/entrypoints/rn_fusebox/rn_fusebox.js",
377-
"front_end/entrypoints/rn_inspector/rn_inspector.js",
378377
"front_end/entrypoints/shell/shell.js",
379378
"front_end/entrypoints/wasmparser_worker/wasmparser_worker-entrypoint.js",
380379
"front_end/entrypoints/wasmparser_worker/wasmparser_worker.js",
@@ -681,7 +680,6 @@ grd_files_release_sources = [
681680
"front_end/panels/recorder/recorder-meta.js",
682681
"front_end/panels/recorder/recorder.js",
683682
"front_end/panels/recorder/util/util.js",
684-
"front_end/panels/rn_welcome/rn_welcome-legacy-meta.js",
685683
"front_end/panels/rn_welcome/rn_welcome-meta.js",
686684
"front_end/panels/rn_welcome/rn_welcome.js",
687685
"front_end/panels/screencast/screencast-meta.js",
@@ -721,7 +719,6 @@ grd_files_release_sources = [
721719
"front_end/panels/whats_new/whats_new.js",
722720
"front_end/rehydrated_devtools_app.html",
723721
"front_end/rn_fusebox.html",
724-
"front_end/rn_inspector.html",
725722
"front_end/services/puppeteer/puppeteer.js",
726723
"front_end/services/trace_bounds/trace_bounds.js",
727724
"front_end/services/tracing/tracing.js",

front_end/BUILD.gn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ group("front_end") {
2828
"entrypoints/node_app:entrypoint",
2929
"entrypoints/rehydrated_devtools_app:entrypoint",
3030
"entrypoints/rn_fusebox:entrypoint",
31-
"entrypoints/rn_inspector:entrypoint",
3231
"entrypoints/shell",
3332
"entrypoints/wasmparser_worker:worker_entrypoint",
3433
"entrypoints/worker_app:entrypoint",
@@ -78,7 +77,6 @@ node_action("html_entrypoints") {
7877
"ndb_app",
7978
"node_app",
8079
"rn_fusebox",
81-
"rn_inspector",
8280
"rehydrated_devtools_app",
8381
"worker_app",
8482
"device_mode_emulation_frame",

front_end/core/host/RNPerfMetrics.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class RNPerfMetrics {
2525
#listeners = new Set<RNReliabilityEventListener>();
2626
#launchId: string|null = null;
2727
#appId: string|null = null;
28-
#entryPoint: EntryPoint = 'rn_inspector';
28+
#entryPoint: EntryPoint = 'rn_fusebox';
2929
#telemetryInfo: Object = {};
3030
// map of panel location to panel name
3131
#currentPanels = new Map<PanelLocation, string>();
@@ -381,7 +381,7 @@ function maybeWrapError(baseMessage: string, error: unknown): [string, Error] {
381381
return [message, new Error(message, {cause: error})];
382382
}
383383

384-
type EntryPoint = 'rn_fusebox'|'rn_inspector';
384+
type EntryPoint = 'rn_fusebox';
385385

386386
type CommonEventFields = Readonly<{
387387
timestamp: DOMHighResTimeStamp,

front_end/core/rn_experiments/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ devtools_entrypoint("bundle") {
2525

2626
visibility = [
2727
"../../entrypoints/rn_fusebox:*",
28-
"../../entrypoints/rn_inspector:*",
2928
"../../entrypoints/main:*",
3029
]
3130
}

front_end/core/rn_experiments/experimentsImpl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
// - define it in the RNExperiments enum and Experiments enum (in Runtime.ts)
2525
// - register it in this file (rn_experiments.ts)
2626
// - set `enabledByDefault` as appropriate
27-
// - optionally, configure it further in each RN-specific entry point
28-
// (rn_inspector.ts, rn_fusebox.ts)
27+
// - optionally, configure it further in the RN-specific entry point
28+
// (rn_fusebox.ts)
2929
//
3030
// React Native-specific experiments are merged into the main ExperimentsSupport
3131
// object in MainImpl and can't be configured further afterwards (except

front_end/entrypoints/inspector_main/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ devtools_entrypoint("meta") {
7171
"../devtools_app/*",
7272
"../rehydrated_devtools_app/*",
7373
"../rn_fusebox:*",
74-
"../rn_inspector:*",
7574
]
7675
}
7776

front_end/entrypoints/main/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ devtools_entrypoint("bundle") {
5757
"../node_app:*",
5858
"../rehydrated_devtools_app:*",
5959
"../rn_fusebox:*",
60-
"../rn_inspector:*",
6160
"../worker_app:*",
6261
]
6362

front_end/entrypoints/rn_inspector/BUILD.gn

Lines changed: 0 additions & 43 deletions
This file was deleted.

front_end/entrypoints/rn_inspector/README.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)