Merged
Conversation
6fc7520 to
473f14c
Compare
motiz88
approved these changes
Jun 11, 2025
motiz88
left a comment
There was a problem hiding this comment.
LGTM. I wonder if there's a way to better preserve the history of the original landing page code. (Also, very silly nit: I don't thing this is a "chore" commit as it includes actual functional changes.)
Author
Probably? I am not sure, maybe partially reverting the original change and then modifying / renaming the file. But since this file was removed, there should be no conflicts in the future, because this is RN-only. I am just expecting that whoever is going to stop by this file would open blame and read this PR, which has some context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the legacy landing page that was removed from the upstream in ChromeDevTools@d0ba98e.
We should revisit this decision in the future when we would be able to show at least some live metrics.
Test plan
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.