feat: Extends default admonitions with a custom important#5064
Merged
Simek merged 4 commits intofacebook:mainfrom Apr 27, 2026
Merged
feat: Extends default admonitions with a custom important#5064Simek merged 4 commits intofacebook:mainfrom
important#5064Simek merged 4 commits intofacebook:mainfrom
Conversation
|
@retyui is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Simek
approved these changes
Apr 27, 2026
Collaborator
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Tested the new theme on the website preview, works as intended and looks great! Thank for working on this! 🙏
Collaborator
|
Made few small tweaks, including TypeScript conversion of the new component, and since we working on admonitions already I have fixed the "Tip" type header shade in light mode (it was too dark): 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importantby default uses info variant: https://github.com/facebook/docusaurus/blob/094248992c5b5e99c8dc8ab3f77d564192736a29/packages/docusaurus-theme-classic/src/theme/Admonition/Types.tsx#L30see: #5062 (comment)
AFTER (Dark, Light):