Skip to content

Commit 2d78a39

Browse files
贾太滨meta-codesync[bot]
authored andcommitted
fix: Register HeadlessJsTaskSupportModule in CoreReactPackage (#56267)
Summary: The `HeadlessJsTaskSupportModule` was not included in any ReactPackage, causing `AppRegistry.notifyTaskFinished()` to fail silently. This meant headless JS tasks would not properly signal completion to the calling service, leaving it to linger unnecessarily. This fix adds `HeadlessJsTaskSupportModule` to `CoreReactPackage` so that `notifyTaskFinished` and `notifyTaskRetry` methods are properly available. ## Changelog [ANDROID] [FIXED] - Register HeadlessJsTaskSupportModule in CoreReactPackage Pull Request resolved: #56267 Test Plan: - [x] Android Kotlin compilation passes - [ ] Verify headless JS tasks can properly call `notifyTaskFinished()` Fixes #56263 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed By: fabriziocucci Differential Revision: D98884467 Pulled By: cortinico fbshipit-source-id: 0e1e88e722d0d353d0469a46fbddda9f11e3c81a
1 parent 664acaf commit 2d78a39

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/CoreReactPackage.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import com.facebook.react.module.model.ReactModuleInfoProvider
2020
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler
2121
import com.facebook.react.modules.core.DeviceEventManagerModule
2222
import com.facebook.react.modules.core.ExceptionsManagerModule
23+
import com.facebook.react.modules.core.HeadlessJsTaskSupportModule
2324
import com.facebook.react.modules.debug.DevMenuModule
2425
import com.facebook.react.modules.debug.DevSettingsModule
2526
import com.facebook.react.modules.debug.SourceCodeModule
@@ -38,6 +39,7 @@ import java.util.HashMap
3839
LogBoxModule::class,
3940
DeviceEventManagerModule::class,
4041
ExceptionsManagerModule::class,
42+
HeadlessJsTaskSupportModule::class,
4143
]
4244
)
4345
internal class CoreReactPackage(
@@ -57,6 +59,7 @@ internal class CoreReactPackage(
5759

5860
LogBoxModule.NAME -> LogBoxModule(reactContext, devSupportManager)
5961
ExceptionsManagerModule.NAME -> ExceptionsManagerModule(devSupportManager)
62+
HeadlessJsTaskSupportModule.NAME -> HeadlessJsTaskSupportModule(reactContext)
6063
else -> null
6164
}
6265

@@ -96,6 +99,7 @@ internal class CoreReactPackage(
9699
DeviceEventManagerModule::class.java,
97100
LogBoxModule::class.java,
98101
ExceptionsManagerModule::class.java,
102+
HeadlessJsTaskSupportModule::class.java,
99103
)
100104
val reactModuleInfoMap: MutableMap<String, ReactModuleInfo> = HashMap()
101105
for (moduleClass in moduleList) {

0 commit comments

Comments
 (0)