Skip to content

Commit 2ff85bc

Browse files
authored
Fix missing header search path for React-featureflags in React-CoreModules (#56592)
RCTRedBox.mm in React-CoreModules imports <react/featureflags/ReactNativeFeatureFlags.h> (added in #56574, RedBox 2.0 iOS backport). With use_frameworks!, this file fails to build with: 'react/featureflags/ReactNativeFeatureFlags.h' file not found (Did not find header 'featureflags/ReactNativeFeatureFlags.h' in framework 'react') React-CoreModules.podspec declared the React-featureflags dependency using plain s.dependency, which only registers the pod. The React-Native-specific add_dependency helper additionally appends the framework's Headers directory (React_featureflags.framework/Headers) to HEADER_SEARCH_PATHS, which is required for Clang to resolve <react/featureflags/...> under use_frameworks!. This aligns React-featureflags with how React-debug, React-runtimeexecutor, React-jsinspector*, React-utils, React-NativeModulesApple, ReactCommon and React-RCTFBReactNativeSpec are already declared in the same podspec. Verified: regenerated React-CoreModules.debug.xcconfig now contains ${PODS_CONFIGURATION_BUILD_DIR}/React-featureflags/React_featureflags.framework/Headers and the build succeeds.
1 parent f04c06d commit 2ff85bc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/React/CoreModules/React-CoreModules.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Pod::Spec.new do |s|
5151
s.dependency "React-Core/CoreModulesHeaders", version
5252
s.dependency "React-RCTImage", version
5353
s.dependency "React-jsi", version
54-
s.dependency "React-featureflags"
54+
add_dependency(s, "React-featureflags")
5555
s.dependency 'React-RCTBlob'
5656
add_dependency(s, "React-debug")
5757
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])

0 commit comments

Comments
 (0)