Commit 2ff85bc
authored
Fix missing header search path for React-featureflags in React-CoreModules (#56592)
RCTRedBox.mm in React-CoreModules imports <react/featureflags/ReactNativeFeatureFlags.h>
(added in #56574, RedBox 2.0 iOS backport). With use_frameworks!, this file fails
to build with:
'react/featureflags/ReactNativeFeatureFlags.h' file not found
(Did not find header 'featureflags/ReactNativeFeatureFlags.h' in framework 'react')
React-CoreModules.podspec declared the React-featureflags dependency using plain
s.dependency, which only registers the pod. The React-Native-specific
add_dependency helper additionally appends the framework's Headers directory
(React_featureflags.framework/Headers) to HEADER_SEARCH_PATHS, which is required
for Clang to resolve <react/featureflags/...> under use_frameworks!.
This aligns React-featureflags with how React-debug, React-runtimeexecutor,
React-jsinspector*, React-utils, React-NativeModulesApple, ReactCommon and
React-RCTFBReactNativeSpec are already declared in the same podspec.
Verified: regenerated React-CoreModules.debug.xcconfig now contains
${PODS_CONFIGURATION_BUILD_DIR}/React-featureflags/React_featureflags.framework/Headers
and the build succeeds.1 parent f04c06d commit 2ff85bc
1 file changed
Lines changed: 1 addition & 1 deletion
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
0 commit comments