Commit 36b3060
ISerialization methods should take in
Summary:
Pull Request resolved: #56410
Missed when we first added the `ISerialization` interface. In JSI APIs,
`Value` is generally passed in as a const reference. This makes it clear
that the actual reference, not the referent, is const.
Fixing the serialization methods to be consistent with the rest of JSI.
Changelog: [Internal]
Reviewed By: lavenzg
Differential Revision: D100222030
fbshipit-source-id: 2297d5c89b90db51269d216e6c3a822d9a4a93abconst jsi::Value& (#56410)1 parent 5087aa0 commit 36b3060
1 file changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
289 | | - | |
| 289 | + | |
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
| |||
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
305 | | - | |
| 305 | + | |
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
| |||
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
316 | | - | |
317 | | - | |
| 316 | + | |
| 317 | + | |
318 | 318 | | |
319 | 319 | | |
320 | 320 | | |
| |||
0 commit comments