Skip to content

Commit 422770d

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Move base64Encode into react/utils (#55873)
Summary: Pull Request resolved: #55873 Move `base64Encode` implementation (originally vendored in D58323859) into `ReactCommon/react/utils/` for reuse in other C++ packages. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95041544 fbshipit-source-id: d71376d03079a8cc4d0a6c3652c40d73374858ea
1 parent d6f2b34 commit 422770d

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/react-native/ReactCommon/jsinspector-modern/NetworkIOAgent.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
#include "NetworkIOAgent.h"
99
#include "InspectorFlags.h"
1010

11-
#include "Base64.h"
1211
#include "Utf8.h"
1312

1413
#include <jsinspector-modern/network/NetworkHandler.h>
14+
#include <react/utils/Base64.h>
1515

1616
#include <sstream>
1717
#include <tuple>

packages/react-native/ReactCommon/jsinspector-modern/Base64.h renamed to packages/react-native/ReactCommon/react/utils/Base64.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include <string>
1111
#include <string_view>
1212

13-
namespace facebook::react::jsinspector_modern {
13+
namespace facebook::react {
1414

1515
namespace {
1616
// Vendored from Folly
@@ -96,4 +96,4 @@ inline std::string base64Encode(const std::string_view s)
9696
return res;
9797
}
9898

99-
} // namespace facebook::react::jsinspector_modern
99+
} // namespace facebook::react

0 commit comments

Comments
 (0)