Skip to content

Commit 6537eba

Browse files
coadometa-codesync[bot]
coado
authored and
meta-codesync[bot]
committed
Change parser config to accept regex in exclude symbols field. (#56367)
Summary: Pull Request resolved: #56367 Adds support for regex in the `exclude_symbols` field in the C++ API parser config. This enables better scoped definitions of symbols that should be matched. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99844594
1 parent 8ac5c28 commit 6537eba

File tree

10 files changed

+115
-125
lines changed

10 files changed

+115
-125
lines changed

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,7 +2166,6 @@ class facebook::react::EventBeat {
21662166
public virtual void requestSynchronous() const;
21672167
public virtual ~EventBeat() = default;
21682168
public void setBeatCallback(facebook::react::EventBeat::BeatCallback beatCallback);
2169-
public void unstable_setInduceCallback(std::function<void()> callback);
21702169
}
21712170

21722171
struct facebook::react::EventBeat::OwnerBox {
@@ -2193,7 +2192,6 @@ class facebook::react::EventDispatcher {
21932192
public void dispatchEvent(facebook::react::RawEvent&& rawEvent) const;
21942193
public void dispatchStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode) const;
21952194
public void dispatchUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2196-
public void experimental_flushSync() const;
21972195
public void removeListener(const std::shared_ptr<const facebook::react::EventListener>& listener) const;
21982196
}
21992197

@@ -2219,8 +2217,6 @@ class facebook::react::EventEmitter {
22192217
public void dispatchUniqueEvent(std::string type, folly::dynamic&& payload, facebook::react::HighResTimeStamp eventTimestamp) const;
22202218
public void setEnabled(bool enabled);
22212219
public void setShadowNodeFamily(std::weak_ptr<const facebook::react::ShadowNodeFamily> shadowNodeFamily);
2222-
template <typename Lambda>
2223-
public void experimental_flushSync(Lambda syncFunc) const;
22242220
}
22252221

22262222
class facebook::react::EventEmitterWrapper : public jni::HybridClass<facebook::react::EventEmitterWrapper> {
@@ -2269,7 +2265,6 @@ class facebook::react::EventQueue {
22692265
public void enqueueEvent(facebook::react::RawEvent&& rawEvent) const;
22702266
public void enqueueStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode = facebook::react::EventQueue::UpdateMode::Asynchronous) const;
22712267
public void enqueueUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2272-
public void experimental_flushSync() const;
22732268
}
22742269

22752270
enum facebook::react::EventQueue::UpdateMode {
@@ -2541,7 +2536,6 @@ class facebook::react::ImageProps : public facebook::react::HostPlatformViewProp
25412536
public facebook::react::ImageSources sources;
25422537
public facebook::react::SharedColor overlayColor;
25432538
public facebook::react::SharedColor tintColor;
2544-
public std::string internal_analyticTag;
25452539
public std::string resizeMethod;
25462540
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
25472541
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
@@ -2823,7 +2817,6 @@ class facebook::react::JReactHostInspectorTarget : public jni::HybridClass<faceb
28232817
public virtual void captureScreenshot(const facebook::react::jsinspector_modern::HostTargetDelegate::PageCaptureScreenshotRequest&, const std::function<void(std::optional<std::string> base64Data)>& callback) override;
28242818
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) override;
28252819
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) override;
2826-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&) override;
28272820
public void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest& params, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener> executor) override;
28282821
public void recordFrameTimings(jni::alias_ref<JFrameTimingSequence::javaobject> frameTimingSequence);
28292822
public void sendDebuggerResumeCommand();
@@ -5179,7 +5172,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
51795172
public std::shared_ptr<const facebook::react::ShadowNode> getNewestCloneOfShadowNode(const facebook::react::ShadowNode& shadowNode) const;
51805173
public std::shared_ptr<facebook::react::ShadowNode> cloneNode(const facebook::react::ShadowNode& shadowNode, const std::shared_ptr<const std::vector<std::shared_ptr<const facebook::react::ShadowNode>>>& children, facebook::react::RawProps rawProps) const;
51815174
public std::shared_ptr<facebook::react::ShadowNode> createNode(facebook::react::Tag tag, const std::string& componentName, facebook::react::SurfaceId surfaceId, facebook::react::RawProps props, facebook::react::InstanceHandle::Shared instanceHandle) const;
5182-
public std::weak_ptr<facebook::react::UIManagerAnimationBackend> unstable_getAnimationBackend();
51835175
public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTree::CommitOptions& commitOptions) const override;
51845176
public virtual void shadowTreeDidFinishReactCommit(const facebook::react::ShadowTree& shadowTree) const override;
51855177
public virtual void shadowTreeDidFinishTransaction(std::shared_ptr<const facebook::react::MountingCoordinator> mountingCoordinator, bool mountSynchronously) const override;
@@ -5208,7 +5200,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
52085200
public void synchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props);
52095201
public void unregisterCommitHook(facebook::react::UIManagerCommitHook& commitHook);
52105202
public void unregisterMountHook(facebook::react::UIManagerMountHook& mountHook);
5211-
public void unstable_setAnimationBackend(std::shared_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
52125203
public void updateShadowTree(std::unordered_map<facebook::react::Tag, folly::dynamic>&& tagToProps);
52135204
public void updateState(const facebook::react::StateUpdate& stateUpdate) const;
52145205
public void visitBinding(const std::function<void(const facebook::react::UIManager::UIManagerBinding& uiManagerBinding)>& callback, facebook::jsi::Runtime& runtime) const;
@@ -10392,7 +10383,6 @@ class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook:
1039210383
public virtual void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest&, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener>) override;
1039310384
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) = 0;
1039410385
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) = 0;
10395-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&);
1039610386
public virtual ~HostTargetDelegate() override;
1039710387
}
1039810388

@@ -10461,7 +10451,6 @@ class facebook::react::jsinspector_modern::ILocalConnection : public facebook::r
1046110451

1046210452
class facebook::react::jsinspector_modern::IPageStatusListener : public facebook::react::jsinspector_modern::IDestructible {
1046310453
public virtual void onPageRemoved(int);
10464-
public virtual void unstable_onHostTargetAdded();
1046510454
public virtual ~IPageStatusListener() = 0;
1046610455
}
1046710456

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2164,7 +2164,6 @@ class facebook::react::EventBeat {
21642164
public virtual void requestSynchronous() const;
21652165
public virtual ~EventBeat() = default;
21662166
public void setBeatCallback(facebook::react::EventBeat::BeatCallback beatCallback);
2167-
public void unstable_setInduceCallback(std::function<void()> callback);
21682167
}
21692168

21702169
struct facebook::react::EventBeat::OwnerBox {
@@ -2191,7 +2190,6 @@ class facebook::react::EventDispatcher {
21912190
public void dispatchEvent(facebook::react::RawEvent&& rawEvent) const;
21922191
public void dispatchStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode) const;
21932192
public void dispatchUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2194-
public void experimental_flushSync() const;
21952193
public void removeListener(const std::shared_ptr<const facebook::react::EventListener>& listener) const;
21962194
}
21972195

@@ -2217,8 +2215,6 @@ class facebook::react::EventEmitter {
22172215
public void dispatchUniqueEvent(std::string type, folly::dynamic&& payload, facebook::react::HighResTimeStamp eventTimestamp) const;
22182216
public void setEnabled(bool enabled);
22192217
public void setShadowNodeFamily(std::weak_ptr<const facebook::react::ShadowNodeFamily> shadowNodeFamily);
2220-
template <typename Lambda>
2221-
public void experimental_flushSync(Lambda syncFunc) const;
22222218
}
22232219

22242220
class facebook::react::EventEmitterWrapper : public jni::HybridClass<facebook::react::EventEmitterWrapper> {
@@ -2267,7 +2263,6 @@ class facebook::react::EventQueue {
22672263
public void enqueueEvent(facebook::react::RawEvent&& rawEvent) const;
22682264
public void enqueueStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode = facebook::react::EventQueue::UpdateMode::Asynchronous) const;
22692265
public void enqueueUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2270-
public void experimental_flushSync() const;
22712266
}
22722267

22732268
enum facebook::react::EventQueue::UpdateMode {
@@ -2538,7 +2533,6 @@ class facebook::react::ImageProps : public facebook::react::HostPlatformViewProp
25382533
public facebook::react::ImageSources sources;
25392534
public facebook::react::SharedColor overlayColor;
25402535
public facebook::react::SharedColor tintColor;
2541-
public std::string internal_analyticTag;
25422536
public std::string resizeMethod;
25432537
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
25442538
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
@@ -2820,7 +2814,6 @@ class facebook::react::JReactHostInspectorTarget : public jni::HybridClass<faceb
28202814
public virtual void captureScreenshot(const facebook::react::jsinspector_modern::HostTargetDelegate::PageCaptureScreenshotRequest&, const std::function<void(std::optional<std::string> base64Data)>& callback) override;
28212815
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) override;
28222816
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) override;
2823-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&) override;
28242817
public void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest& params, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener> executor) override;
28252818
public void recordFrameTimings(jni::alias_ref<JFrameTimingSequence::javaobject> frameTimingSequence);
28262819
public void sendDebuggerResumeCommand();
@@ -5170,7 +5163,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
51705163
public std::shared_ptr<const facebook::react::ShadowNode> getNewestCloneOfShadowNode(const facebook::react::ShadowNode& shadowNode) const;
51715164
public std::shared_ptr<facebook::react::ShadowNode> cloneNode(const facebook::react::ShadowNode& shadowNode, const std::shared_ptr<const std::vector<std::shared_ptr<const facebook::react::ShadowNode>>>& children, facebook::react::RawProps rawProps) const;
51725165
public std::shared_ptr<facebook::react::ShadowNode> createNode(facebook::react::Tag tag, const std::string& componentName, facebook::react::SurfaceId surfaceId, facebook::react::RawProps props, facebook::react::InstanceHandle::Shared instanceHandle) const;
5173-
public std::weak_ptr<facebook::react::UIManagerAnimationBackend> unstable_getAnimationBackend();
51745166
public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTree::CommitOptions& commitOptions) const override;
51755167
public virtual void shadowTreeDidFinishReactCommit(const facebook::react::ShadowTree& shadowTree) const override;
51765168
public virtual void shadowTreeDidFinishTransaction(std::shared_ptr<const facebook::react::MountingCoordinator> mountingCoordinator, bool mountSynchronously) const override;
@@ -5199,7 +5191,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
51995191
public void synchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props);
52005192
public void unregisterCommitHook(facebook::react::UIManagerCommitHook& commitHook);
52015193
public void unregisterMountHook(facebook::react::UIManagerMountHook& mountHook);
5202-
public void unstable_setAnimationBackend(std::shared_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
52035194
public void updateShadowTree(std::unordered_map<facebook::react::Tag, folly::dynamic>&& tagToProps);
52045195
public void updateState(const facebook::react::StateUpdate& stateUpdate) const;
52055196
public void visitBinding(const std::function<void(const facebook::react::UIManager::UIManagerBinding& uiManagerBinding)>& callback, facebook::jsi::Runtime& runtime) const;
@@ -10248,7 +10239,6 @@ class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook:
1024810239
public virtual void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest&, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener>) override;
1024910240
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) = 0;
1025010241
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) = 0;
10251-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&);
1025210242
public virtual ~HostTargetDelegate() override;
1025310243
}
1025410244

@@ -10317,7 +10307,6 @@ class facebook::react::jsinspector_modern::ILocalConnection : public facebook::r
1031710307

1031810308
class facebook::react::jsinspector_modern::IPageStatusListener : public facebook::react::jsinspector_modern::IDestructible {
1031910309
public virtual void onPageRemoved(int);
10320-
public virtual void unstable_onHostTargetAdded();
1032110310
public virtual ~IPageStatusListener() = 0;
1032210311
}
1032310312

0 commit comments

Comments
 (0)