Fix const-correctness for EventTarget (#55681)

Summary:
Pull Request resolved: #55681

Changelog: [Internal]

Remove incorrect const qualifier from setter/modifier methods in EventTarget.

This is part of a larger effort to fix const-correctness throughout the
React Native Fabric codebase.

Reviewed By: javache

Differential Revision: D90763776

fbshipit-source-id: 06ba88ea3082f792e1b38660ad67a3f6ce7b0845

Author: sammy-SC

packages/react-native/ReactCommon/react/renderer/core/EventPipe.h

@@ -20,7 +20,7 @@ namespace facebook::react {
 
 using EventPipe = std::function<void(
     jsi::Runtime &runtime,
-    const EventTarget *eventTarget,
+    EventTarget *eventTarget,
     const std::string &type,
     ReactEventPriority priority,
     const EventPayload &payload)>;

packages/react-native/ReactCommon/react/renderer/core/EventTarget.cpp

@@ -20,11 +20,11 @@ EventTarget::EventTarget(
       surfaceId_(surfaceId),
       strongInstanceHandle_(jsi::Value::null()) {}
 
-void EventTarget::setEnabled(bool enabled) const {
+void EventTarget::setEnabled(bool enabled) {
   enabled_ = enabled;
 }
 
-void EventTarget::retain(jsi::Runtime& runtime) const {
+void EventTarget::retain(jsi::Runtime& runtime) {
   if (!enabled_) {
     return;
   }
@@ -46,7 +46,7 @@ void EventTarget::retain(jsi::Runtime& runtime) const {
   // react_native_assert(!strongInstanceHandle_.isUndefined());
 }
 
-void EventTarget::release(jsi::Runtime& /*runtime*/) const {
+void EventTarget::release(jsi::Runtime& /*runtime*/) {
   // The method does not use `jsi::Runtime` reference.
   // It takes it only to ensure thread-safety (if the caller has the reference,
   // we are on a proper thread).

packages/react-native/ReactCommon/react/renderer/core/EventTarget.h

@@ -40,18 +40,18 @@ class EventTarget {
    * Sets the `enabled` flag that allows creating a strong instance handle from
    * a weak one.
    */
-  void setEnabled(bool enabled) const;
+  void setEnabled(bool enabled);
 
   /*
    * Retains an instance handler by creating a strong reference to it.
    * If the EventTarget is disabled, does nothing.
    */
-  void retain(jsi::Runtime &runtime) const;
+  void retain(jsi::Runtime &runtime);
 
   /*
    * Releases the instance handler by nulling a strong reference to it.
    */
-  void release(jsi::Runtime &runtime) const;
+  void release(jsi::Runtime &runtime);
 
   /*
    * Creates and returns the `instanceHandle`.
@@ -69,11 +69,11 @@ class EventTarget {
  private:
   const InstanceHandle::Shared instanceHandle_;
   const SurfaceId surfaceId_;
-  mutable bool enabled_{false}; // Protected by `EventEmitter::DispatchMutex()`.
-  mutable jsi::Value strongInstanceHandle_; // Protected by `jsi::Runtime &`.
-  mutable size_t retainCount_{0}; // Protected by `jsi::Runtime &`.
+  bool enabled_{false}; // Protected by `EventEmitter::DispatchMutex()`.
+  jsi::Value strongInstanceHandle_; // Protected by `jsi::Runtime &`.
+  size_t retainCount_{0}; // Protected by `jsi::Runtime &`.
 };
 
-using SharedEventTarget = std::shared_ptr<const EventTarget>;
+using SharedEventTarget = std::shared_ptr<EventTarget>;
 
 } // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp

@@ -85,7 +85,7 @@ Scheduler::Scheduler(
 
   auto eventPipe = [uiManager](
                        jsi::Runtime& runtime,
-                       const EventTarget* eventTarget,
+                       EventTarget* eventTarget,
                        const std::string& type,
                        ReactEventPriority priority,
                        const EventPayload& payload) {

packages/react-native/ReactCommon/react/renderer/uimanager/PointerEventsProcessor.cpp

@@ -15,7 +15,7 @@ namespace facebook::react {
 std::shared_ptr<const ShadowNode>
 PointerEventsProcessor::getShadowNodeFromEventTarget(
     jsi::Runtime& runtime,
-    const EventTarget* target) {
+    EventTarget* target) {
   if (target != nullptr) {
     target->retain(runtime);
     auto instanceHandle = target->getInstanceHandle(runtime);

packages/react-native/ReactCommon/react/renderer/uimanager/PointerEventsProcessor.h

@@ -47,9 +47,7 @@ using PointerHoverTrackerRegistry = std::unordered_map<PointerIdentifier, Pointe
 
 class PointerEventsProcessor final {
  public:
-  static std::shared_ptr<const ShadowNode> getShadowNodeFromEventTarget(
-      jsi::Runtime &runtime,
-      const EventTarget *target);
+  static std::shared_ptr<const ShadowNode> getShadowNodeFromEventTarget(jsi::Runtime &runtime, EventTarget *target);
 
   void interceptPointerEvent(
       const std::shared_ptr<const ShadowNode> &target,

packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

@@ -62,7 +62,7 @@ UIManagerBinding::~UIManagerBinding() {
 
 void UIManagerBinding::dispatchEvent(
     jsi::Runtime& runtime,
-    const EventTarget* eventTarget,
+    EventTarget* eventTarget,
     const std::string& type,
     ReactEventPriority priority,
     const EventPayload& eventPayload) const {
@@ -101,7 +101,7 @@ void UIManagerBinding::dispatchEvent(
 
 void UIManagerBinding::dispatchEventToJS(
     jsi::Runtime& runtime,
-    const EventTarget* eventTarget,
+    EventTarget* eventTarget,
     const std::string& type,
     ReactEventPriority priority,
     const EventPayload& eventPayload) const {

packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.h

@@ -44,7 +44,7 @@ class UIManagerBinding : public jsi::HostObject {
    */
   void dispatchEvent(
       jsi::Runtime &runtime,
-      const EventTarget *eventTarget,
+      EventTarget *eventTarget,
       const std::string &type,
       ReactEventPriority priority,
       const EventPayload &payload) const;
@@ -73,7 +73,7 @@ class UIManagerBinding : public jsi::HostObject {
    */
   void dispatchEventToJS(
       jsi::Runtime &runtime,
-      const EventTarget *eventTarget,
+      EventTarget *eventTarget,
       const std::string &type,
       ReactEventPriority priority,
       const EventPayload &payload) const;