Make DevSupportHttpClient internal (#55883)

Summary:
Pull Request resolved: #55883

All 7 callers of DevSupportHttpClient are within ReactAndroid, so
there is no need to expose it as a public API. Make the class and all
its members internal.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D95059038

fbshipit-source-id: 7aeb04503ac5eaa538cbb8b4d9352ae97d165ea0

Author: cortinico

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -2049,16 +2049,6 @@ public final class com/facebook/react/devsupport/StackTraceHelper$StackFrameImpl
 	public fun toJSON ()Lorg/json/JSONObject;
 }
 
-public final class com/facebook/react/devsupport/inspector/DevSupportHttpClient {
-	public static final field INSTANCE Lcom/facebook/react/devsupport/inspector/DevSupportHttpClient;
-	public static final fun addRequestHeader (Ljava/lang/String;Ljava/lang/String;)V
-	public final fun getHttpClient ()Lokhttp3/OkHttpClient;
-	public final fun getWebsocketClient ()Lokhttp3/OkHttpClient;
-	public static final fun httpScheme (Ljava/lang/String;)Ljava/lang/String;
-	public static final fun removeRequestHeader (Ljava/lang/String;)V
-	public static final fun wsScheme (Ljava/lang/String;)Ljava/lang/String;
-}
-
 public abstract interface class com/facebook/react/devsupport/interfaces/BundleLoadCallback {
 	public fun onError (Ljava/lang/Exception;)V
 	public abstract fun onSuccess ()V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/DevSupportHttpClient.kt

@@ -19,7 +19,7 @@ import okhttp3.OkHttpClient
  * dispatcher across all dev support HTTP and WebSocket usage. Supports injecting custom request
  * headers that are applied to every outgoing request via an OkHttp interceptor.
  */
-public object DevSupportHttpClient {
+internal object DevSupportHttpClient {
   private val customHeaders = ConcurrentHashMap<String, String>()
 
   private val headerInterceptor = Interceptor { chain ->
@@ -31,7 +31,7 @@ public object DevSupportHttpClient {
   }
 
   /** Client for HTTP requests: connect=5s, write=disabled, read=disabled. */
-  public val httpClient: OkHttpClient =
+  internal val httpClient: OkHttpClient =
       OkHttpClient.Builder()
           .addInterceptor(headerInterceptor)
           .connectTimeout(5, TimeUnit.SECONDS)
@@ -40,35 +40,32 @@ public object DevSupportHttpClient {
           .build()
 
   /** Client for WebSocket connections: connect=10s, write=10s, read=disabled. */
-  public val websocketClient: OkHttpClient =
+  internal val websocketClient: OkHttpClient =
       httpClient
           .newBuilder()
           .connectTimeout(10, TimeUnit.SECONDS)
           .writeTimeout(10, TimeUnit.SECONDS)
           .build()
 
   /** Add a custom header to be included in all requests made through both clients. */
-  @JvmStatic
-  public fun addRequestHeader(name: String, value: String) {
+  internal fun addRequestHeader(name: String, value: String) {
     customHeaders[name] = value
   }
 
   /** Remove a previously added custom header. */
-  @JvmStatic
-  public fun removeRequestHeader(name: String) {
+  internal fun removeRequestHeader(name: String) {
     customHeaders.remove(name)
   }
 
   /**
    * Returns the appropriate HTTP scheme ("http" or "https") for the given host. Uses "https" when
    * the host specifies port 443 explicitly (e.g. "example.com:443").
    */
-  @JvmStatic
-  public fun httpScheme(host: String): String = if (host.endsWith(":443")) "https" else "http"
+  internal fun httpScheme(host: String): String = if (host.endsWith(":443")) "https" else "http"
 
   /**
    * Returns the appropriate WebSocket scheme ("ws" or "wss") for the given host. Uses "wss" when
    * the host specifies port 443 explicitly (e.g. "example.com:443").
    */
-  @JvmStatic public fun wsScheme(host: String): String = if (host.endsWith(":443")) "wss" else "ws"
+  internal fun wsScheme(host: String): String = if (host.endsWith(":443")) "wss" else "ws"
 }