Skip to content

Commit 8944bb3

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Fix unused parameter warnings in IMountingManager.h (#56488)
Summary: Pull Request resolved: #56488 Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Reviewed By: javache Differential Revision: D101110289 fbshipit-source-id: ee9bf593b648c6db8e0764613b29e47036fd7df8
1 parent e8feade commit 8944bb3

1 file changed

Lines changed: 18 additions & 15 deletions

File tree

packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -40,29 +40,32 @@ class IMountingManager {
4040
virtual void
4141
dispatchCommand(const ShadowView &shadowView, const std::string &commandName, const folly::dynamic &args) = 0;
4242

43-
virtual void setIsJSResponder(const ShadowView &shadowView, bool isJSResponder, bool blockNativeResponder) {};
43+
virtual void
44+
setIsJSResponder(const ShadowView & /* shadowView */, bool /* isJSResponder */, bool /* blockNativeResponder */)
45+
{
46+
}
4447

45-
virtual void synchronouslyUpdateViewOnUIThread(Tag reactTag, const folly::dynamic &changedProps) {};
48+
virtual void synchronouslyUpdateViewOnUIThread(Tag /* reactTag */, const folly::dynamic & /* changedProps */) {}
4649

47-
virtual void onUpdateShadowTree(const std::unordered_map<Tag, folly::dynamic> &tagToProps) {};
50+
virtual void onUpdateShadowTree(const std::unordered_map<Tag, folly::dynamic> & /* tagToProps */) {}
4851

49-
virtual void initializeAccessibilityManager() {};
52+
virtual void initializeAccessibilityManager() {}
5053

51-
virtual void setAccessibilityFocusedView(Tag viewTag) {};
54+
virtual void setAccessibilityFocusedView(Tag /* viewTag */) {}
5255

53-
virtual void setFocusedView(Tag viewTag) {};
56+
virtual void setFocusedView(Tag /* viewTag */) {}
5457

55-
virtual void clearAccessibilityFocusedView(Tag viewTag) {};
58+
virtual void clearAccessibilityFocusedView(Tag /* viewTag */) {}
5659

57-
virtual void accessibleClickAction(Tag viewTag) {};
60+
virtual void accessibleClickAction(Tag /* viewTag */) {}
5861

59-
virtual void accessibleScrollInDirection(Tag viewTag, int direction) {};
62+
virtual void accessibleScrollInDirection(Tag /* viewTag */, int /* direction */) {}
6063

61-
virtual void accessibleSetText(Tag viewTag, const std::string &text) {};
64+
virtual void accessibleSetText(Tag /* viewTag */, const std::string & /* text */) {}
6265

63-
virtual void clearFocusedView(Tag viewTag) {};
66+
virtual void clearFocusedView(Tag /* viewTag */) {}
6467

65-
virtual void setAfterMountCallback(std::function<void(SurfaceId)> &&onAfterMount) {};
68+
virtual void setAfterMountCallback(std::function<void(SurfaceId)> && /* onAfterMount */) {}
6669

6770
virtual ComponentRegistryFactory getComponentRegistryFactory()
6871
{
@@ -74,11 +77,11 @@ class IMountingManager {
7477
return false;
7578
}
7679

77-
virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor &&schedulerTaskExecutor) noexcept {};
80+
virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor && /* schedulerTaskExecutor */) noexcept {}
7881

79-
virtual void setEventEmitterListener(std::shared_ptr<EventEmitterListener> listener) noexcept {};
82+
virtual void setEventEmitterListener(std::shared_ptr<EventEmitterListener> /* listener */) noexcept {}
8083

81-
virtual void setUIManager(std::weak_ptr<UIManager> uiManager) noexcept {};
84+
virtual void setUIManager(std::weak_ptr<UIManager> /* uiManager */) noexcept {}
8285

8386
virtual std::shared_ptr<IImageLoader> getImageLoader() noexcept
8487
{

0 commit comments

Comments
 (0)