Deprecate and replace obscure ShadowNode type aliases (#55690)

Summary:
Pull Request resolved: #55690

Changelog: [internal]

Mark these obscure type aliases as deprecated and replace all usages with explicit types:
- `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>`
- `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>`
- `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>`

the type aliases will be deleted later.

Reviewed By: lenaic

Differential Revision: D90331677

fbshipit-source-id: 1323766a9e725e75e3a45c14c259cd3a61f11388

Author: sammy-SC

packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp

@@ -36,7 +36,8 @@ thread_local bool useRuntimeShadowNodeReferenceUpdateOnThread{false}; // NOLINT
   return useRuntimeShadowNodeReferenceUpdateOnThread;
 }
 
-ShadowNode::SharedListOfShared ShadowNode::emptySharedShadowNodeSharedList() {
+std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>
+ShadowNode::emptySharedShadowNodeSharedList() {
   static const auto emptySharedShadowNodeSharedList =
       std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>();
   return emptySharedShadowNodeSharedList;

packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h

@@ -30,14 +30,19 @@ struct ShadowNodeWrapper;
 
 class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::NativeState {
  public:
-  using SharedListOfShared = std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>;
-  using UnsharedListOfShared = std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>;
-  using UnsharedListOfWeak = std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>;
+  using SharedListOfShared
+      [[deprecated("Use std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>> instead")]] =
+          std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>;
+  using UnsharedListOfShared
+      [[deprecated("Use std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> instead")]] =
+          std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>;
+  using UnsharedListOfWeak [[deprecated("Use std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>> instead")]] =
+      std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>;
 
   using AncestorList =
       std::vector<std::pair<std::reference_wrapper<const ShadowNode> /* parentNode */, int /* childIndex */>>;
 
-  static SharedListOfShared emptySharedShadowNodeSharedList();
+  static std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>> emptySharedShadowNodeSharedList();
 
   /*
    * Returns `true` if nodes belong to the same family (they were cloned one
@@ -226,7 +231,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
 
  protected:
   Props::Shared props_;
-  SharedListOfShared children_;
+  std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>> children_;
   State::Shared state_;
   int orderIndex_;
 

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFragment.cpp

@@ -20,9 +20,11 @@ const Props::Shared& ShadowNodeFragment::propsPlaceholder() {
   return instance;
 }
 
-const ShadowNode::SharedListOfShared&
+const std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>&
 ShadowNodeFragment::childrenPlaceholder() {
-  NO_DESTROY static ShadowNode::SharedListOfShared instance;
+  NO_DESTROY static std::shared_ptr<
+      const std::vector<std::shared_ptr<const ShadowNode>>>
+      instance;
   return instance;
 }
 

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFragment.h

@@ -24,7 +24,7 @@ namespace facebook::react {
  */
 struct ShadowNodeFragment {
   const Props::Shared &props = propsPlaceholder();
-  const ShadowNode::SharedListOfShared &children = childrenPlaceholder();
+  const std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>> &children = childrenPlaceholder();
   const State::Shared &state = statePlaceholder();
   const bool runtimeShadowNodeReference = true;
 
@@ -34,7 +34,7 @@ struct ShadowNodeFragment {
    * be changed.
    */
   static const Props::Shared &propsPlaceholder();
-  static const ShadowNode::SharedListOfShared &childrenPlaceholder();
+  static const std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>> &childrenPlaceholder();
   static const State::Shared &statePlaceholder();
 };
 

packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp

@@ -224,8 +224,8 @@ std::shared_ptr<const ShadowNode> SurfaceHandler::dirtyMeasurableNodesRecursive(
     return nullptr;
   }
 
-  ShadowNode::SharedListOfShared newChildren =
-      ShadowNodeFragment::childrenPlaceholder();
+  std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>
+      newChildren = ShadowNodeFragment::childrenPlaceholder();
 
   if (nodeHasChildren) {
     std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>

packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

@@ -107,7 +107,8 @@ std::shared_ptr<ShadowNode> UIManager::createNode(
 
 std::shared_ptr<ShadowNode> UIManager::cloneNode(
     const ShadowNode& shadowNode,
-    const ShadowNode::SharedListOfShared& children,
+    const std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>&
+        children,
     RawProps rawProps) const {
   TraceSection s(
       "UIManager::cloneNode", "componentName", shadowNode.getComponentName());
@@ -184,7 +185,8 @@ void UIManager::appendChild(
 
 void UIManager::completeSurface(
     SurfaceId surfaceId,
-    const ShadowNode::UnsharedListOfShared& rootChildren,
+    const std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>&
+        rootChildren,
     ShadowTree::CommitOptions commitOptions) {
   TraceSection s("UIManager::completeSurface", "surfaceId", surfaceId);
 

packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

@@ -146,16 +146,18 @@ class UIManager final : public ShadowTreeDelegate {
       RawProps props,
       InstanceHandle::Shared instanceHandle) const;
 
-  std::shared_ptr<ShadowNode>
-  cloneNode(const ShadowNode &shadowNode, const ShadowNode::SharedListOfShared &children, RawProps rawProps) const;
+  std::shared_ptr<ShadowNode> cloneNode(
+      const ShadowNode &shadowNode,
+      const std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>> &children,
+      RawProps rawProps) const;
 
   void appendChild(
       const std::shared_ptr<const ShadowNode> &parentShadowNode,
       const std::shared_ptr<const ShadowNode> &childShadowNode) const;
 
   void completeSurface(
       SurfaceId surfaceId,
-      const ShadowNode::UnsharedListOfShared &rootChildren,
+      const std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> &rootChildren,
       ShadowTree::CommitOptions commitOptions);
 
   void setIsJSResponder(

packages/react-native/ReactCommon/react/renderer/uimanager/primitives.h

@@ -19,14 +19,17 @@ namespace facebook::react {
 using BackgroundExecutor = std::function<void(std::function<void()> &&callback)>;
 
 struct ShadowNodeListWrapper : public jsi::NativeState {
-  ShadowNodeListWrapper(ShadowNode::UnsharedListOfShared shadowNodeList) : shadowNodeList(std::move(shadowNodeList)) {}
+  ShadowNodeListWrapper(std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> shadowNodeList)
+      : shadowNodeList(std::move(shadowNodeList))
+  {
+  }
 
   // The below method needs to be implemented out-of-line in order for the class
   // to have at least one "key function" (see
   // https://itanium-cxx-abi.github.io/cxx-abi/abi.html#vague-vtable)
   ~ShadowNodeListWrapper() override;
 
-  ShadowNode::UnsharedListOfShared shadowNodeList;
+  std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> shadowNodeList;
 };
 
 inline static jsi::Value valueFromShadowNode(
@@ -48,7 +51,9 @@ inline static jsi::Value valueFromShadowNode(
 
 // TODO: once we no longer need to mutate the return value (appendChildToSet)
 // make this a SharedListOfShared
-inline static ShadowNode::UnsharedListOfShared shadowNodeListFromValue(jsi::Runtime &runtime, const jsi::Value &value)
+inline static std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> shadowNodeListFromValue(
+    jsi::Runtime &runtime,
+    const jsi::Value &value)
 {
   // TODO: cleanup when passChildrenWhenCloningPersistedNodes is rolled out
   jsi::Object object = value.asObject(runtime);
@@ -75,7 +80,9 @@ inline static ShadowNode::UnsharedListOfShared shadowNodeListFromValue(jsi::Runt
   }
 }
 
-inline static jsi::Value valueFromShadowNodeList(jsi::Runtime &runtime, ShadowNode::UnsharedListOfShared shadowNodeList)
+inline static jsi::Value valueFromShadowNodeList(
+    jsi::Runtime &runtime,
+    std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> shadowNodeList)
 {
   auto wrapper = std::make_shared<ShadowNodeListWrapper>(std::move(shadowNodeList));
   // Use the wrapper for NativeState too, otherwise we can't implement
@@ -85,8 +92,8 @@ inline static jsi::Value valueFromShadowNodeList(jsi::Runtime &runtime, ShadowNo
   return obj;
 }
 
-inline static ShadowNode::UnsharedListOfShared shadowNodeListFromWeakList(
-    const ShadowNode::UnsharedListOfWeak &weakShadowNodeList)
+inline static std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> shadowNodeListFromWeakList(
+    const std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>> &weakShadowNodeList)
 {
   auto result = std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>();
   for (const auto &weakShadowNode : *weakShadowNodeList) {
@@ -99,7 +106,9 @@ inline static ShadowNode::UnsharedListOfShared shadowNodeListFromWeakList(
   return result;
 }
 
-inline static ShadowNode::UnsharedListOfWeak weakShadowNodeListFromValue(jsi::Runtime &runtime, const jsi::Value &value)
+inline static std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>> weakShadowNodeListFromValue(
+    jsi::Runtime &runtime,
+    const jsi::Value &value)
 {
   auto shadowNodeList = shadowNodeListFromValue(runtime, value);
   auto weakShadowNodeList = std::make_shared<std::vector<std::weak_ptr<const ShadowNode>>>();