Remove double-conversion dependency and also DoubleConversions.cpp and replace it with DebugStringConvertible (#56110)

Summary:
Pull Request resolved: #56110

**Summary**

Removes the `double-conversion` dependency from `DoubleConversions.cpp` in the React Native repository.

- Removed Dependencies: `double-conversion/double-conversion.h`

 Updated Code

* Modified `DoubleConversions.cpp` to use standard C++ library headers (`cmath` and `cstdio`) instead of `double-conversion`.

This change aims to reduce dependencies and simplify the codebase. The removed dependency was previously used for string conversion, which has been replaced with standard C++ library functions.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D96082175

Author: christophpurrer

packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt

@@ -99,8 +99,8 @@ add_react_common_subdir(react/renderer/css)
 add_react_common_subdir(react/renderer/uimanager/consistency)
 add_react_common_subdir(react/renderer/dom)
 add_react_common_subdir(react/renderer/element)
-add_react_common_subdir(react/renderer/graphics)
 add_react_common_subdir(react/renderer/debug)
+add_react_common_subdir(react/renderer/graphics)
 add_react_common_subdir(react/renderer/imagemanager)
 add_react_common_subdir(react/renderer/components/view)
 add_react_common_subdir(react/renderer/components/switch)

packages/react-native/ReactCommon/react/renderer/debug/DebugStringConvertible.cpp

@@ -14,6 +14,42 @@
 
 namespace facebook::react {
 
+/*
+ * `toString`-family implementation.
+ */
+std::string toString(const double& value) {
+  // Handle special floating-point values with prettier output
+  if (std::isnan(value)) {
+    return "NaN";
+  }
+  if (std::isinf(value)) {
+    return value < 0 ? "-Infinity" : "Infinity";
+  }
+
+  std::ostringstream stream;
+  stream << std::fixed << std::setprecision(4) << value;
+  std::string result = stream.str();
+
+  // Strip trailing zeros and unnecessary decimal point
+  if (auto dotPos = result.find('.'); dotPos != std::string::npos) {
+    auto lastNonZero = result.find_last_not_of('0');
+    if (lastNonZero == dotPos) {
+      result.erase(dotPos);
+    } else {
+      result.erase(lastNonZero + 1);
+    }
+  }
+  return result;
+}
+
+std::string toString(const double doubleValue, char suffix) {
+  auto result = toString(doubleValue);
+  if (suffix != '\0') {
+    result += suffix;
+  }
+  return result;
+}
+
 #if RN_DEBUG_STRING_CONVERTIBLE
 
 std::string DebugStringConvertible::getDebugChildrenDescription(
@@ -124,34 +160,6 @@ SharedDebugStringConvertibleList DebugStringConvertible::getDebugProps() const {
   return {};
 }
 
-/*
- * `toString`-family implementation.
- */
-std::string toString(const double& value) {
-  // Handle special floating-point values with prettier output
-  if (std::isnan(value)) {
-    return "NaN";
-  }
-  if (std::isinf(value)) {
-    return value < 0 ? "-Infinity" : "Infinity";
-  }
-
-  std::ostringstream stream;
-  stream << std::fixed << std::setprecision(4) << value;
-  std::string result = stream.str();
-
-  // Strip trailing zeros and unnecessary decimal point
-  if (auto dotPos = result.find('.'); dotPos != std::string::npos) {
-    auto lastNonZero = result.find_last_not_of('0');
-    if (lastNonZero == dotPos) {
-      result.erase(dotPos);
-    } else {
-      result.erase(lastNonZero + 1);
-    }
-  }
-  return result;
-}
-
 std::string toString(const void* value) {
   if (value == nullptr) {
     return "null";

packages/react-native/ReactCommon/react/renderer/debug/DebugStringConvertible.h

@@ -81,13 +81,15 @@ class DebugStringConvertible {};
 
 #endif
 
-#if RN_DEBUG_STRING_CONVERTIBLE
-
 /*
  * Set of particular-format-opinionated functions that convert base types to
  * `std::string`
  */
 std::string toString(const double &value);
+std::string toString(const double doubleValue, char suffix);
+
+#if RN_DEBUG_STRING_CONVERTIBLE
+
 std::string toString(const void *value);
 
 inline std::string toString(const std::string &value)

packages/react-native/ReactCommon/react/renderer/debug/tests/DebugStringConvertibleTest.cpp

@@ -5,14 +5,44 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#if RN_DEBUG_STRING_CONVERTIBLE
-#include <memory>
+#include <limits>
 
 #include <gtest/gtest.h>
-#include <react/renderer/debug/DebugStringConvertibleItem.h>
+#include <react/renderer/debug/DebugStringConvertible.h>
 
 using namespace facebook::react;
 
+TEST(DebugStringConvertibleTest, toStringDoubleWithSuffix) {
+  EXPECT_EQ(toString(3.14, '%'), "3.14%");
+  EXPECT_EQ(toString(100.0, 'x'), "100x");
+}
+
+TEST(DebugStringConvertibleTest, toStringDoubleWithNullSuffix) {
+  auto result = toString(42.0, '\0');
+  EXPECT_EQ(result, "42");
+}
+
+TEST(DebugStringConvertibleTest, toStringDoubleWithSuffixZeroValue) {
+  EXPECT_EQ(toString(0.0, '%'), "0%");
+}
+
+TEST(DebugStringConvertibleTest, toStringDoubleWithSuffixNegativeValue) {
+  EXPECT_EQ(toString(-2.75, '%'), "-2.75%");
+}
+
+TEST(DebugStringConvertibleTest, toStringDoubleWithSuffixSpecialValues) {
+  EXPECT_EQ(
+      toString(std::numeric_limits<double>::infinity(), '%'), "Infinity%");
+  EXPECT_EQ(
+      toString(-std::numeric_limits<double>::infinity(), '%'), "-Infinity%");
+  EXPECT_EQ(toString(std::numeric_limits<double>::quiet_NaN(), 'x'), "NaNx");
+}
+
+#if RN_DEBUG_STRING_CONVERTIBLE
+#include <memory>
+
+#include <react/renderer/debug/DebugStringConvertibleItem.h>
+
 TEST(DebugStringConvertibleTest, handleSimpleNode) {
   SharedDebugStringConvertibleList empty;
   auto item = std::make_shared<DebugStringConvertibleItem>(
@@ -83,4 +113,5 @@ TEST(DebugStringConvertibleTest, handleNodeWithComplexProps) {
       item->getDebugDescription().c_str(),
       "<View=hello x=1(height=100 width=200)/>");
 }
+
 #endif

packages/react-native/ReactCommon/react/renderer/graphics/CMakeLists.txt

@@ -30,6 +30,7 @@ target_link_libraries(react_renderer_graphics
         ${fbjni}
         folly_runtime
         react_debug
+        react_renderer_debug
         react_utils
 )
 target_compile_reactnative_options(react_renderer_graphics PRIVATE)

packages/react-native/ReactCommon/react/renderer/graphics/DoubleConversions.cpp

@@ -49,6 +49,7 @@ Pod::Spec.new do |s|
   s.dependency "React-jsiexecutor"
   s.dependency "React-featureflags"
   s.dependency "React-utils"
+  s.dependency "React-rendererdebug"
 
   depend_on_js_engine(s)
   add_rn_third_party_dependencies(s)

packages/react-native/ReactCommon/react/renderer/graphics/DoubleConversions.h

@@ -7,7 +7,7 @@
 
 #include "ValueUnit.h"
 
-#include "DoubleConversions.h"
+#include <react/renderer/debug/DebugStringConvertible.h>
 
 namespace facebook::react {