Add global exclude patterns to the cxx api config (#56248)

Summary:
Pull Request resolved: #56248

Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform.

Changelog:
[Internal]

Reviewed By: cortinico

Differential Revision: D97465431

fbshipit-source-id: e71daef90853dad8003a0f41b1ea78b8c56bee02

Author: coado

scripts/cxx-api/config.yml

@@ -1,85 +1,82 @@
-ReactCommon:
-  codegen:
-  inputs:
-    - packages/react-native/ReactCommon
-  exclude_patterns:
-    - "*/test_utils/*"
-    - "*/test/*"
-    - "*/jni/*"
-    - "*/platform/cxx/*" # Should this be included in ReactCommon?
-    - "*/platform/windows/*"
-    - "*/platform/macos/*"
-    - "*/platform/ios/*"
-    - "*/platform/android/*"
-  input_filter: false
-  definitions:
-  variants:
-    debug:
-      definitions:
-        DEBUG: 1
-        REACT_NATIVE_DEBUG: 1
-    release:
-      definitions:
-        NDEBUG: 1
-        REACT_NATIVE_PRODUCTION: 1
+exclude_patterns:
+  - "*/test_utils/*"
+  - "*/test/*"
 
-ReactAndroid:
-  codegen:
-    platform: android
-  inputs:
-    - packages/react-native/ReactCommon
-    - packages/react-native/ReactAndroid
-  exclude_patterns:
-    - "*/test_utils/*"
-    - "*/test/*"
-    - "*/platform/cxx/*"
-    - "*/platform/windows/*"
-    - "*/platform/macos/*"
-    - "*/platform/ios/*"
-  input_filter: false
-  definitions:
-    RN_SERIALIZABLE_STATE: 1
-    ANDROID: 1
-  variants:
-    debug:
-      definitions:
-        DEBUG: 1
-        REACT_NATIVE_DEBUG: 1
-    release:
-      definitions:
-        NDEBUG: 1
-        REACT_NATIVE_PRODUCTION: 1
-
-# ReactIOS?
-ReactApple:
-  codegen:
-    platform: ios
-  inputs:
-    - packages/react-native/ReactCommon
-    - packages/react-native/React
-    - packages/react-native/ReactApple
-    - packages/react-native/Libraries
-  exclude_patterns:
-    - "*/test_utils/*"
-    - "*/test/*"
-    - "*/jni/*"
-    - "*/platform/cxx/*"
-    - "*/platform/windows/*"
-    - "*/platform/macos/*"
-    - "*/platform/android/*"
-    - "*+Private.h"
-    - "*+Internal.h"
-    - "*/scripts/*"
-    - "*/templates/*"
-  input_filter: true
-  definitions:
-    __cplusplus: 1
-  variants:
-    debug:
-      definitions:
-        DEBUG: 1
-        REACT_NATIVE_DEBUG: 1
-    release:
-      definitions:
-        NDEBUG: 1
-        REACT_NATIVE_PRODUCTION: 1
+platforms:
+  ReactCommon:
+    codegen:
+    inputs:
+      - packages/react-native/ReactCommon
+    exclude_patterns:
+      - "*/jni/*"
+      - "*/platform/cxx/*" # Should this be included in ReactCommon?
+      - "*/platform/windows/*"
+      - "*/platform/macos/*"
+      - "*/platform/ios/*"
+      - "*/platform/android/*"
+    input_filter: false
+    definitions:
+    variants:
+      debug:
+        definitions:
+          DEBUG: 1
+          REACT_NATIVE_DEBUG: 1
+      release:
+        definitions:
+          NDEBUG: 1
+          REACT_NATIVE_PRODUCTION: 1
+  ReactAndroid:
+    codegen:
+      platform: android
+    inputs:
+      - packages/react-native/ReactCommon
+      - packages/react-native/ReactAndroid
+    exclude_patterns:
+      - "*/platform/cxx/*"
+      - "*/platform/windows/*"
+      - "*/platform/macos/*"
+      - "*/platform/ios/*"
+    input_filter: false
+    definitions:
+      RN_SERIALIZABLE_STATE: 1
+      ANDROID: 1
+    variants:
+      debug:
+        definitions:
+          DEBUG: 1
+          REACT_NATIVE_DEBUG: 1
+      release:
+        definitions:
+          NDEBUG: 1
+          REACT_NATIVE_PRODUCTION: 1
+  # ReactIOS?
+  ReactApple:
+    codegen:
+      platform: ios
+    inputs:
+      - packages/react-native/ReactCommon
+      - packages/react-native/React
+      - packages/react-native/ReactApple
+      - packages/react-native/Libraries
+    exclude_patterns:
+      - "*/jni/*"
+      - "*/platform/cxx/*"
+      - "*/platform/windows/*"
+      - "*/platform/macos/*"
+      - "*/platform/android/*"
+      - "*+Private.h"
+      - "*+Internal.h"
+      - "*/scripts/*"
+      - "*/templates/*"
+    input_filter: true
+    definitions:
+      __cplusplus: 1
+    variants:
+      debug:
+        definitions:
+          DEBUG: 1
+          REACT_NATIVE_DEBUG: 1
+      release:
+        definitions:
+          NDEBUG: 1
+          REACT_NATIVE_PRODUCTION: 1

scripts/cxx-api/parser/config.py

@@ -47,17 +47,24 @@ def parse_config(
     """
     Parse a raw config dictionary and return a flattened list of snapshot configs.
 
+    The config must contain:
+      - An optional top-level ``exclude_patterns`` list that is prepended to
+        every platform's own ``exclude_patterns``.
+      - A ``platforms`` mapping whose values are per-platform view configs.
+
     Args:
         raw_config: Dictionary containing the parsed YAML config
         base_dir: Base directory for resolving relative input paths
-        codegen_path: Optional path to codegen generated code
 
     Returns:
         Flattened list of ApiViewSnapshotConfig objects for all views and variants
     """
+    global_exclude_patterns: list[str] = raw_config.get("exclude_patterns") or []
+    platforms: dict = raw_config.get("platforms") or {}
+
     snapshot_configs = []
 
-    for view_name, view_config in raw_config.items():
+    for view_name, view_config in platforms.items():
         inputs = [
             path if path.startswith("/") else os.path.join(base_dir, path)
             for path in (view_config.get("inputs") or [])
@@ -69,6 +76,15 @@ def parse_config(
         input_filter = view_config.get("input_filter", False)
         base_definitions = view_config.get("definitions") or {}
 
+        exclude_platform_patterns = view_config.get("exclude_patterns") or []
+        seen: set[str] = set()
+        merged_patterns: list[str] = []
+        for pattern in global_exclude_patterns + exclude_platform_patterns:
+            if pattern not in seen:
+                merged_patterns.append(pattern)
+                seen.add(pattern)
+        exclude_patterns = merged_patterns
+
         raw_variants = view_config.get("variants") or {}
         variants = [
             ApiViewVariant(
@@ -117,7 +133,6 @@ def parse_config_file(
     Args:
         config_path: Path to the config.yml file
         base_dir: Base directory for resolving relative input paths
-        codegen_path: Optional path to codegen generated code
 
     Returns:
         Flattened list of ApiViewSnapshotConfig objects for all views and variants