Skip to content

Commit cf646c9

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Delete useTurboModules() from ReactNativeNewArchitectureFeatureFlags (#56900)
Summary: The `useTurboModules()` flag is being removed entirely; it was always set to true in the canary release stage. All callers of `ReactNativeNewArchitectureFeatureFlags.useTurboModules()` were inlined in earlier diffs. This diff: - Removes the wrapper method `ReactNativeNewArchitectureFeatureFlags.useTurboModules()`. - Removes the `override fun useTurboModules(): Boolean = true` from `ReactNativeNewArchitectureFeatureFlagsDefaults`. Both classes are non-`generated`, so they are edited directly. A follow-up diff will flip the underlying `ReactNativeFeatureFlags.useTurboModules()` default to `true` and ultimately remove the API by regenerating the codegen output. Behavior is unchanged. Changelog: [Internal] Differential Revision: D105718202
1 parent 11e3857 commit cf646c9

2 files changed

Lines changed: 0 additions & 14 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlags.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,4 @@ public object ReactNativeNewArchitectureFeatureFlags {
5858
}
5959
return ReactNativeFeatureFlags.useTurboModuleInterop()
6060
}
61-
62-
@JvmStatic
63-
public fun useTurboModules(): Boolean {
64-
if (ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE) {
65-
Assertions.assertCondition(
66-
ReactNativeFeatureFlags.useTurboModules(),
67-
"ReactNativeFeatureFlags.useTurboModules() should be set to TRUE when Strict Mode is enabled",
68-
)
69-
return true
70-
}
71-
return ReactNativeFeatureFlags.useTurboModules()
72-
}
7361
}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,4 @@ public open class ReactNativeNewArchitectureFeatureFlagsDefaults() :
2828
override fun useNativeViewConfigsInBridgelessMode(): Boolean = true
2929

3030
override fun useTurboModuleInterop(): Boolean = true
31-
32-
override fun useTurboModules(): Boolean = true
3331
}

0 commit comments

Comments
 (0)