Skip to content

Commit d6f2b34

Browse files
fabriziocuccimeta-codesync[bot]
authored andcommitted
Back out "Use stable Hermes for dry-run builds on stable branches" (#55877)
Summary: Pull Request resolved: #55877 Changelog: [Internal] Original commit changeset: d5888a00b29c Original Phabricator Diff: D95022571 It turns out, this didn't fix the issue. Reviewed By: cipolleschi Differential Revision: D95051094 fbshipit-source-id: f99ecc0b76a1bdf4ba2eb3117b08754dfbbc2558
1 parent a1062a8 commit d6f2b34

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

.github/actions/build-android/action.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,7 @@ runs:
5454
if [[ "${{ inputs.release-type }}" == "dry-run" ]]; then
5555
# dry-run: we only build ARM64 to save time/resources. For release/nightlies the default is to build all archs.
5656
export ORG_GRADLE_PROJECT_reactNativeArchitectures="arm64-v8a,x86" # x86 is required for E2E testing
57-
# Use stable Hermes on stable branches, nightly Hermes on main
58-
if [[ "${{ github.ref_name }}" == *"-stable" ]] || [[ "${{ github.base_ref }}" == *"-stable" ]]; then
59-
export HERMES_PREBUILT_FLAG="ORG_GRADLE_PROJECT_react.internal.useHermesStable=true"
60-
else
61-
export HERMES_PREBUILT_FLAG="ORG_GRADLE_PROJECT_react.internal.useHermesNightly=true"
62-
fi
57+
export HERMES_PREBUILT_FLAG="ORG_GRADLE_PROJECT_react.internal.useHermesNightly=true"
6358
TASKS="publishAllToMavenTempLocal build"
6459
elif [[ "${{ inputs.release-type }}" == "nightly" ]]; then
6560
# nightly: we set isSnapshot to true so artifacts are sent to the right repository on Maven Central.

0 commit comments

Comments
 (0)