Skip to content

Commit d98a3b8

Browse files
coadometa-codesync[bot]
authored andcommitted
Exclude InputAccessory component from the ReactAndroid C++ API snapshot
Summary: Excludes InputAccessory which is an iOS-only component with no Android support at any layer. In the `InputAccessoryView.js` there is explicit iOS guard which logs warning on Android. Changelog: [Internal] Differential Revision: D98478125
1 parent d0a0b5c commit d98a3b8

3 files changed

Lines changed: 3 additions & 58 deletions

File tree

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,6 @@ const char facebook::react::AndroidTextInputComponentName[];
457457
const char facebook::react::ImageComponentName[];
458458
const char facebook::react::ImageFetcherKey[];
459459
const char facebook::react::ImageManagerKey[];
460-
const char facebook::react::InputAccessoryComponentName[];
461460
const char facebook::react::LegacyViewManagerAndroidInteropComponentName[];
462461
const char facebook::react::LegacyViewManagerInteropComponentName[];
463462
const char facebook::react::ModalHostViewComponentName[];
@@ -2674,34 +2673,6 @@ class facebook::react::ImageTelemetry {
26742673
public facebook::react::TelemetryTimePoint getWillRequestUrlTime() const;
26752674
}
26762675

2677-
class facebook::react::InputAccessoryComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::InputAccessoryShadowNode> {
2678-
public InputAccessoryComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
2679-
public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
2680-
}
2681-
2682-
class facebook::react::InputAccessoryEventEmitter : public facebook::react::BaseViewEventEmitter {
2683-
}
2684-
2685-
class facebook::react::InputAccessoryProps : public facebook::react::HostPlatformViewProps {
2686-
public InputAccessoryProps() = default;
2687-
public InputAccessoryProps(const facebook::react::PropsParserContext& context, const facebook::react::InputAccessoryProps& sourceProps, const facebook::react::RawProps& rawProps);
2688-
public facebook::react::SharedColor backgroundColor;
2689-
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
2690-
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
2691-
}
2692-
2693-
class facebook::react::InputAccessoryShadowNode : public facebook::react::ConcreteViewShadowNode<facebook::react::InputAccessoryComponentName, facebook::react::InputAccessoryProps, facebook::react::InputAccessoryEventEmitter, facebook::react::InputAccessoryState> {
2694-
public InputAccessoryShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
2695-
public InputAccessoryShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
2696-
public static facebook::react::ShadowNodeTraits BaseTraits();
2697-
}
2698-
2699-
class facebook::react::InputAccessoryState {
2700-
public InputAccessoryState();
2701-
public InputAccessoryState(facebook::react::Size viewportSize_);
2702-
public const facebook::react::Size viewportSize;
2703-
}
2704-
27052676
class facebook::react::InspectorNetworkRequestListener : public jni::HybridClass<facebook::react::InspectorNetworkRequestListener> {
27062677
public static constexpr auto kJavaDescriptor;
27072678
public static void registerNatives();

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,6 @@ const char facebook::react::AndroidTextInputComponentName[];
457457
const char facebook::react::ImageComponentName[];
458458
const char facebook::react::ImageFetcherKey[];
459459
const char facebook::react::ImageManagerKey[];
460-
const char facebook::react::InputAccessoryComponentName[];
461460
const char facebook::react::LegacyViewManagerAndroidInteropComponentName[];
462461
const char facebook::react::LegacyViewManagerInteropComponentName[];
463462
const char facebook::react::ModalHostViewComponentName[];
@@ -2671,34 +2670,6 @@ class facebook::react::ImageTelemetry {
26712670
public facebook::react::TelemetryTimePoint getWillRequestUrlTime() const;
26722671
}
26732672

2674-
class facebook::react::InputAccessoryComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::InputAccessoryShadowNode> {
2675-
public InputAccessoryComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
2676-
public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
2677-
}
2678-
2679-
class facebook::react::InputAccessoryEventEmitter : public facebook::react::BaseViewEventEmitter {
2680-
}
2681-
2682-
class facebook::react::InputAccessoryProps : public facebook::react::HostPlatformViewProps {
2683-
public InputAccessoryProps() = default;
2684-
public InputAccessoryProps(const facebook::react::PropsParserContext& context, const facebook::react::InputAccessoryProps& sourceProps, const facebook::react::RawProps& rawProps);
2685-
public facebook::react::SharedColor backgroundColor;
2686-
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
2687-
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
2688-
}
2689-
2690-
class facebook::react::InputAccessoryShadowNode : public facebook::react::ConcreteViewShadowNode<facebook::react::InputAccessoryComponentName, facebook::react::InputAccessoryProps, facebook::react::InputAccessoryEventEmitter, facebook::react::InputAccessoryState> {
2691-
public InputAccessoryShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
2692-
public InputAccessoryShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
2693-
public static facebook::react::ShadowNodeTraits BaseTraits();
2694-
}
2695-
2696-
class facebook::react::InputAccessoryState {
2697-
public InputAccessoryState();
2698-
public InputAccessoryState(facebook::react::Size viewportSize_);
2699-
public const facebook::react::Size viewportSize;
2700-
}
2701-
27022673
class facebook::react::InspectorNetworkRequestListener : public jni::HybridClass<facebook::react::InspectorNetworkRequestListener> {
27032674
public static constexpr auto kJavaDescriptor;
27042675
public static void registerNatives();

scripts/cxx-api/config.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,13 @@ platforms:
4444
exclude_patterns:
4545
- "*/ReactAndroid/src/main/jni/react/featureflags/*"
4646
- "*/components/switch/iosswitch/*"
47+
- "*/components/inputaccessory/*"
4748
- "*/platform/cxx/*"
4849
- "*/platform/windows/*"
4950
- "*/platform/macos/*"
5051
- "*/platform/ios/*"
52+
exclude_symbols:
53+
- "InputAccessory"
5154
input_filter: false
5255
definitions:
5356
RN_SERIALIZABLE_STATE: 1

0 commit comments

Comments
 (0)