Skip to content

Commit e0935e6

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Update test_js job to be dependent on lint (#55428)
Summary: Pull Request resolved: #55428 With a lighter weight `lint` job, make this blocking for `test_js` runs. The combined `lint` + `test_js` execution time in series remains far less than the native build+test jobs. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92417805 fbshipit-source-id: 05832257518c8141ca0955f18e740f752e675d4d
1 parent 7e75234 commit e0935e6

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -486,21 +486,6 @@ jobs:
486486
flavor: ${{ matrix.flavor }}
487487
use-frameworks: ${{ matrix.use_frameworks }}
488488

489-
test_js:
490-
runs-on: ubuntu-latest
491-
if: github.repository == 'facebook/react-native'
492-
strategy:
493-
fail-fast: false
494-
matrix:
495-
node-version: ["24", "22", "20.19.4"]
496-
steps:
497-
- name: Checkout
498-
uses: actions/checkout@v6
499-
- name: Test JS
500-
uses: ./.github/actions/test-js
501-
with:
502-
node-version: ${{ matrix.node-version }}
503-
504489
lint:
505490
runs-on: ubuntu-latest
506491
if: github.repository == 'facebook/react-native'
@@ -531,6 +516,21 @@ jobs:
531516
shell: bash
532517
run: yarn test-typescript
533518

519+
test_js:
520+
runs-on: ubuntu-latest
521+
needs: lint
522+
strategy:
523+
fail-fast: false
524+
matrix:
525+
node-version: ["24", "22", "20.19.4"]
526+
steps:
527+
- name: Checkout
528+
uses: actions/checkout@v6
529+
- name: Test JS
530+
uses: ./.github/actions/test-js
531+
with:
532+
node-version: ${{ matrix.node-version }}
533+
534534
build_js_types:
535535
runs-on: ubuntu-latest
536536
needs: lint

0 commit comments

Comments
 (0)