Remove redundant operator!= definitions in react-native-github (#55746)

Summary:
Pull Request resolved: #55746

X-link: facebook/yoga#1892

C++20 automatically generates `operator!=` from `operator==`, making explicit `operator!=` definitions redundant. This removes all such redundant definitions across the React Native C++ codebase, including:

- Simple negation patterns (`return !(*this == rhs)`)
- Explicit `= default` declarations that duplicate the compiler-generated behavior
- Both member and free-function forms

Files in jsi/ were excluded as they are mirrored to a project that may not support C++20.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D94370249

fbshipit-source-id: f1c73d38a61ff9e780bd16a797e6ce71b1900d00

Author: NickGerleman

packages/react-native/Libraries/FBLazyVector/FBLazyVector/FBLazyIterator.h

@@ -116,12 +116,6 @@ LazyIterator<T, U> operator+(typename LazyIterator<T, U>::difference_type n, con
   return i + n;
 }
 
-template <typename T, typename U>
-bool operator!=(const LazyIterator<T, U> &a, const LazyIterator<T, U> &b)
-{
-  return !(a == b);
-}
-
 template <typename T, typename U>
 bool operator<=(const LazyIterator<T, U> &a, const LazyIterator<T, U> &b)
 {

packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h

@@ -22,10 +22,6 @@ struct UniqueMonostate {
   {
     return true;
   }
-  constexpr bool operator!=(const UniqueMonostate<key> & /*unused*/) const noexcept
-  {
-    return false;
-  }
   constexpr bool operator<(const UniqueMonostate<key> & /*unused*/) const noexcept
   {
     return false;

packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.cpp

@@ -79,10 +79,4 @@ bool operator==(
   }
 }
 
-bool operator!=(
-    const AttributedStringBox& lhs,
-    const AttributedStringBox& rhs) {
-  return !(lhs == rhs);
-}
-
 } // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h

@@ -58,7 +58,6 @@ class AttributedStringBox final {
 };
 
 bool operator==(const AttributedStringBox &lhs, const AttributedStringBox &rhs);
-bool operator!=(const AttributedStringBox &lhs, const AttributedStringBox &rhs);
 
 } // namespace facebook::react
 

packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.cpp

@@ -36,10 +36,6 @@ bool ParagraphAttributes::operator==(const ParagraphAttributes& rhs) const {
       floatEquality(minimumFontScale, rhs.minimumFontScale);
 }
 
-bool ParagraphAttributes::operator!=(const ParagraphAttributes& rhs) const {
-  return !(*this == rhs);
-}
-
 #pragma mark - DebugStringConvertible
 
 #if RN_DEBUG_STRING_CONVERTIBLE

packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h

@@ -83,7 +83,6 @@ class ParagraphAttributes : public DebugStringConvertible {
   std::optional<TextAlignmentVertical> textAlignVertical{};
 
   bool operator==(const ParagraphAttributes &rhs) const;
-  bool operator!=(const ParagraphAttributes &rhs) const;
 
 #pragma mark - DebugStringConvertible
 

packages/react-native/ReactCommon/react/renderer/components/scrollview/primitives.h

@@ -30,11 +30,6 @@ class ScrollViewMaintainVisibleContentPosition final {
     return std::tie(this->minIndexForVisible, this->autoscrollToTopThreshold) ==
         std::tie(rhs.minIndexForVisible, rhs.autoscrollToTopThreshold);
   }
-
-  bool operator!=(const ScrollViewMaintainVisibleContentPosition &rhs) const
-  {
-    return !(*this == rhs);
-  }
 };
 
 } // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h

@@ -56,11 +56,6 @@ inline static bool operator==(const AccessibilityAction &lhs, const Accessibilit
   return lhs.name == rhs.name && lhs.label == rhs.label;
 }
 
-inline static bool operator!=(const AccessibilityAction &lhs, const AccessibilityAction &rhs)
-{
-  return !(rhs == lhs);
-}
-
 struct AccessibilityState {
   bool disabled{false};
   bool selected{false};
@@ -76,11 +71,6 @@ constexpr bool operator==(const AccessibilityState &lhs, const AccessibilityStat
       lhs.busy == rhs.busy && lhs.expanded == rhs.expanded;
 }
 
-constexpr bool operator!=(const AccessibilityState &lhs, const AccessibilityState &rhs)
-{
-  return !(rhs == lhs);
-}
-
 struct AccessibilityLabelledBy {
   std::vector<std::string> value{};
 };
@@ -90,11 +80,6 @@ inline static bool operator==(const AccessibilityLabelledBy &lhs, const Accessib
   return lhs.value == rhs.value;
 }
 
-inline static bool operator!=(const AccessibilityLabelledBy &lhs, const AccessibilityLabelledBy &rhs)
-{
-  return !(lhs == rhs);
-}
-
 struct AccessibilityValue {
   std::optional<int> min;
   std::optional<int> max;
@@ -107,11 +92,6 @@ constexpr bool operator==(const AccessibilityValue &lhs, const AccessibilityValu
   return lhs.min == rhs.min && lhs.max == rhs.max && lhs.now == rhs.now && lhs.text == rhs.text;
 }
 
-constexpr bool operator!=(const AccessibilityValue &lhs, const AccessibilityValue &rhs)
-{
-  return !(rhs == lhs);
-}
-
 enum class ImportantForAccessibility : uint8_t {
   Auto,
   Yes,

packages/react-native/ReactCommon/react/renderer/components/view/primitives.h

@@ -85,11 +85,6 @@ inline static bool operator==(const ViewEvents &lhs, const ViewEvents &rhs)
   return lhs.bits == rhs.bits;
 }
 
-inline static bool operator!=(const ViewEvents &lhs, const ViewEvents &rhs)
-{
-  return lhs.bits != rhs.bits;
-}
-
 enum class BackfaceVisibility : uint8_t { Auto, Visible, Hidden };
 
 enum class BorderCurve : uint8_t { Circular, Continuous };
@@ -212,11 +207,6 @@ struct CascadedRectangleEdges {
                rhs.blockStart,
                rhs.blockEnd);
   }
-
-  bool operator!=(const CascadedRectangleEdges<T> &rhs) const
-  {
-    return !(*this == rhs);
-  }
 };
 
 template <typename T>
@@ -292,11 +282,6 @@ struct CascadedRectangleCorners {
                rhs.startEnd,
                rhs.startStart);
   }
-
-  bool operator!=(const CascadedRectangleCorners<T> &rhs) const
-  {
-    return !(*this == rhs);
-  }
 };
 
 using BorderWidths = RectangleEdges<Float>;
@@ -324,11 +309,6 @@ struct BorderMetrics {
                this->borderColors, this->borderWidths, this->borderRadii, this->borderCurves, this->borderStyles) ==
         std::tie(rhs.borderColors, rhs.borderWidths, rhs.borderRadii, rhs.borderCurves, rhs.borderStyles);
   }
-
-  bool operator!=(const BorderMetrics &rhs) const
-  {
-    return !(*this == rhs);
-  }
 };
 
 } // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/core/LayoutConstraints.h

@@ -36,11 +36,6 @@ inline bool operator==(const LayoutConstraints &lhs, const LayoutConstraints &rh
       std::tie(rhs.minimumSize, rhs.maximumSize, rhs.layoutDirection);
 }
 
-inline bool operator!=(const LayoutConstraints &lhs, const LayoutConstraints &rhs)
-{
-  return !(lhs == rhs);
-}
-
 } // namespace facebook::react
 
 namespace std {