Skip to content

Commit fe78779

Browse files
cortinicometa-codesync[bot]
cortinico
authored and
meta-codesync[bot]
committed
Migrate ReactShadowNode interface from Java to Kotlin
Summary: Migrate the `ReactShadowNode` interface from Java to Kotlin as part of the ongoing Kotlin migration effort. This is a mechanical conversion of a deprecated legacy architecture interface with no functional changes. The interface is a pure declaration with no default implementations. Changelog: [Android][Changed] - Migrate `ReactShadowNode` interface from Java to Kotlin Differential Revision: D106079764
1 parent 3d50561 commit fe78779

5 files changed

Lines changed: 515 additions & 429 deletions

File tree

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/LayoutShadowNode.kt‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
9595

9696
@ReactProp(name = ViewProps.WIDTH)
9797
public open fun setWidth(width: Dynamic) {
98-
if (isVirtual) {
98+
if (isVirtual()) {
9999
return
100100
}
101101

@@ -113,7 +113,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
113113

114114
@ReactProp(name = ViewProps.MIN_WIDTH)
115115
public open fun setMinWidth(minWidth: Dynamic) {
116-
if (isVirtual) {
116+
if (isVirtual()) {
117117
return
118118
}
119119

@@ -142,7 +142,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
142142

143143
@ReactProp(name = ViewProps.MAX_WIDTH)
144144
public open fun setMaxWidth(maxWidth: Dynamic) {
145-
if (isVirtual) {
145+
if (isVirtual()) {
146146
return
147147
}
148148

@@ -159,7 +159,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
159159

160160
@ReactProp(name = ViewProps.HEIGHT)
161161
public open fun setHeight(height: Dynamic) {
162-
if (isVirtual) {
162+
if (isVirtual()) {
163163
return
164164
}
165165

@@ -177,7 +177,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
177177

178178
@ReactProp(name = ViewProps.MIN_HEIGHT)
179179
public open fun setMinHeight(minHeight: Dynamic) {
180-
if (isVirtual) {
180+
if (isVirtual()) {
181181
return
182182
}
183183

@@ -194,7 +194,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
194194

195195
@ReactProp(name = ViewProps.MAX_HEIGHT)
196196
public open fun setMaxHeight(maxHeight: Dynamic) {
197-
if (isVirtual) {
197+
if (isVirtual()) {
198198
return
199199
}
200200

@@ -212,7 +212,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
212212
@Override
213213
@ReactProp(name = ViewProps.FLEX, defaultFloat = 0f)
214214
public override fun setFlex(flex: Float) {
215-
if (isVirtual) {
215+
if (isVirtual()) {
216216
return
217217
}
218218
super.setFlex(flex)
@@ -221,15 +221,15 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
221221
@Override
222222
@ReactProp(name = ViewProps.FLEX_GROW, defaultFloat = 0f)
223223
public override fun setFlexGrow(flexGrow: Float) {
224-
if (isVirtual) {
224+
if (isVirtual()) {
225225
return
226226
}
227227
super.setFlexGrow(flexGrow)
228228
}
229229

230230
@ReactProp(name = ViewProps.ROW_GAP)
231231
public open fun setRowGap(rowGap: Dynamic) {
232-
if (isVirtual) {
232+
if (isVirtual()) {
233233
return
234234
}
235235

@@ -247,7 +247,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
247247

248248
@ReactProp(name = ViewProps.COLUMN_GAP)
249249
public open fun setColumnGap(columnGap: Dynamic) {
250-
if (isVirtual) {
250+
if (isVirtual()) {
251251
return
252252
}
253253

@@ -265,7 +265,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
265265

266266
@ReactProp(name = ViewProps.GAP)
267267
public open fun setGap(gap: Dynamic) {
268-
if (isVirtual) {
268+
if (isVirtual()) {
269269
return
270270
}
271271

@@ -284,15 +284,15 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
284284
@Override
285285
@ReactProp(name = ViewProps.FLEX_SHRINK, defaultFloat = 0f)
286286
public override fun setFlexShrink(flexShrink: Float) {
287-
if (isVirtual) {
287+
if (isVirtual()) {
288288
return
289289
}
290290
super.setFlexShrink(flexShrink)
291291
}
292292

293293
@ReactProp(name = ViewProps.FLEX_BASIS)
294294
public open fun setFlexBasis(flexBasis: Dynamic) {
295-
if (isVirtual) {
295+
if (isVirtual()) {
296296
return
297297
}
298298

@@ -315,7 +315,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
315315

316316
@ReactProp(name = ViewProps.FLEX_DIRECTION)
317317
public open fun setFlexDirection(flexDirection: String?) {
318-
if (isVirtual) {
318+
if (isVirtual()) {
319319
return
320320
}
321321

@@ -338,7 +338,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
338338

339339
@ReactProp(name = ViewProps.FLEX_WRAP)
340340
public open fun setFlexWrap(flexWrap: String?) {
341-
if (isVirtual) {
341+
if (isVirtual()) {
342342
return
343343
}
344344

@@ -360,7 +360,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
360360

361361
@ReactProp(name = ViewProps.ALIGN_SELF)
362362
public open fun setAlignSelf(alignSelf: String?) {
363-
if (isVirtual) {
363+
if (isVirtual()) {
364364
return
365365
}
366366

@@ -387,7 +387,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
387387

388388
@ReactProp(name = ViewProps.ALIGN_ITEMS)
389389
public open fun setAlignItems(alignItems: String?) {
390-
if (isVirtual) {
390+
if (isVirtual()) {
391391
return
392392
}
393393

@@ -414,7 +414,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
414414

415415
@ReactProp(name = ViewProps.ALIGN_CONTENT)
416416
public open fun setAlignContent(alignContent: String?) {
417-
if (isVirtual) {
417+
if (isVirtual()) {
418418
return
419419
}
420420

@@ -442,7 +442,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
442442

443443
@ReactProp(name = ViewProps.JUSTIFY_CONTENT)
444444
public open fun setJustifyContent(justifyContent: String?) {
445-
if (isVirtual) {
445+
if (isVirtual()) {
446446
return
447447
}
448448

@@ -467,7 +467,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
467467

468468
@ReactProp(name = ViewProps.OVERFLOW)
469469
public open fun setOverflow(overflow: String?) {
470-
if (isVirtual) {
470+
if (isVirtual()) {
471471
return
472472
}
473473
if (overflow == null) {
@@ -488,7 +488,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
488488

489489
@ReactProp(name = ViewProps.DISPLAY)
490490
public open fun setDisplay(display: String?) {
491-
if (isVirtual) {
491+
if (isVirtual()) {
492492
return
493493
}
494494

@@ -575,7 +575,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
575575
]
576576
)
577577
public open fun setMargins(index: Int, margin: Dynamic) {
578-
if (isVirtual) {
578+
if (isVirtual()) {
579579
return
580580
}
581581

@@ -609,7 +609,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
609609
]
610610
)
611611
public open fun setPaddings(index: Int, padding: Dynamic) {
612-
if (isVirtual) {
612+
if (isVirtual()) {
613613
return
614614
}
615615

@@ -641,7 +641,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
641641
defaultFloat = Float.NaN,
642642
)
643643
public open fun setBorderWidths(index: Int, borderWidth: Float) {
644-
if (isVirtual) {
644+
if (isVirtual()) {
645645
return
646646
}
647647
val spacingType = maybeTransformLeftRightToStartEnd(ViewProps.BORDER_SPACING_TYPES[index])
@@ -660,7 +660,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
660660
]
661661
)
662662
public open fun setPositionValues(index: Int, position: Dynamic) {
663-
if (isVirtual) {
663+
if (isVirtual()) {
664664
return
665665
}
666666

@@ -688,7 +688,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
688688
}
689689

690690
private fun maybeTransformLeftRightToStartEnd(spacingType: Int): Int {
691-
if (!I18nUtil.getInstance().doLeftAndRightSwapInRTL(themedContext)) {
691+
if (!I18nUtil.getInstance().doLeftAndRightSwapInRTL(getThemedContext())) {
692692
return spacingType
693693
}
694694

@@ -701,7 +701,7 @@ public open class LayoutShadowNode : ReactShadowNodeImpl() {
701701

702702
@ReactProp(name = ViewProps.POSITION)
703703
public open fun setPosition(position: String?) {
704-
if (isVirtual) {
704+
if (isVirtual()) {
705705
return
706706
}
707707

0 commit comments

Comments
 (0)