Replace FIXME comment with explanation for JS safety in MutationObserver#56271
Closed
rubennorte wants to merge 1 commit into
Closed
Replace FIXME comment with explanation for JS safety in MutationObserver#56271rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
Summary: Replace the FIXME(T157129303) comment in NativeMutationObserver with a clarifying comment explaining why it is safe to call into JS at that point: we only check mutations synchronously when committing from React, so we are already in a JS task. Changelog: [Internal] Differential Revision: D98714071
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98714071. |
|
This pull request has been merged in 185a613. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 185a613 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the FIXME(T157129303) comment in NativeMutationObserver with a
clarifying comment explaining why it is safe to call into JS at that
point: we only check mutations synchronously when committing from React,
so we are already in a JS task.
Changelog: [Internal]
Differential Revision: D98714071