Skip to content

[jest-preset] Fix mock for Linking#54067

Open
jzaefferer wants to merge 1 commit intofacebook:mainfrom
jzaefferer:patch-1
Open

[jest-preset] Fix mock for Linking#54067
jzaefferer wants to merge 1 commit intofacebook:mainfrom
jzaefferer:patch-1

Conversation

@jzaefferer
Copy link
Copy Markdown

@jzaefferer jzaefferer commented Oct 6, 2025

Summary:

All three patched methods are supposed to return Promise<any>. Having the mock return undefined for them breaks tests that expect the Promise.

Changelog:

[General] [Fixed] - Fix mock for Linking methods to return Promises

Test Plan

I'm using this patch on my own project, it works fine there. I don't think it's worth trying to write an automated test for this.

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Oct 6, 2025

Hi @jzaefferer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Oct 6, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 6, 2025
@react-native-bot
Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 6, 2026
All three patched methods are supposed to return `Promise<any>`. Having the mock return `undefined` for them breaks tests that expect the Promise.
@jzaefferer
Copy link
Copy Markdown
Author

GitHub claimed there were merge conflicts. There weren't, but I rebased it anyway.

Would be great to get this merged, so I don't have to maintain this patch in two places. Or fight off the bot adding the stale label.

@react-native-bot react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants