[jest-preset] Fix mock for Linking#54067
Conversation
|
Hi @jzaefferer! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
All three patched methods are supposed to return `Promise<any>`. Having the mock return `undefined` for them breaks tests that expect the Promise.
|
GitHub claimed there were merge conflicts. There weren't, but I rebased it anyway. Would be great to get this merged, so I don't have to maintain this patch in two places. Or fight off the bot adding the stale label. |
Summary:
All three patched methods are supposed to return
Promise<any>. Having the mock returnundefinedfor them breaks tests that expect the Promise.Changelog:
[General] [Fixed] - Fix mock for Linking methods to return Promises
Test Plan
I'm using this patch on my own project, it works fine there. I don't think it's worth trying to write an automated test for this.