Add ExtraWindowEventListener interface#55721
Conversation
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D94871845. |
9fdaf8d to
6620980
Compare
268f25a to
f832c91
Compare
f832c91 to
3791a05
Compare
3791a05 to
935b7de
Compare
|
This would be huge for me to fix current production issues with the new Android policy to enforce edge to edge. |
cortinico
left a comment
There was a problem hiding this comment.
Can you write some tests for this newly created API?
|
Also do we need an iOS equivalent? |
|
@cortinico The main goal of this change is to allow updating the system UI style and visibility in modals (and other registered dialogs / activities), and it's not an issue on iOS. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@alanleedev merged this pull request in 58fec1f. |
|
This pull request was successfully merged by @zoontek in 58fec1f When will my fix make it into a release? | How to file a pick request? |
Summary:
This PR introduces a
ExtraWindowEventListenerinterface that allows native modules to be notified when new windows are created or destroyed (e.g. Modal dialogs).Third-party libraries can implement it, or emit window events through
ReactContext.onExtraWindowCreate/ReactContext.onExtraWindowDestroy.This opens the door for libraries like
expo-navigation-barto build a properNavigationBarmodule that stays in sync across all windows (including modals).Related issue
Changelog:
[ANDROID] [ADDED] - Add
ExtraWindowEventListenerinterface to allow native modules to react to window creation / destruction (e.g. Modal dialogs)Test Plan
Follow #56059 test plan