Stub NativeViewHierarchyManager and clean up usages#55758
Closed
mdvacca wants to merge 1 commit intofacebook:mainfrom
Closed
Stub NativeViewHierarchyManager and clean up usages#55758mdvacca wants to merge 1 commit intofacebook:mainfrom
mdvacca wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Stub out NativeViewHierarchyManager by removing all fields, private methods, and method body implementations while keeping all public method signatures with empty bodies for backward compatibility with third-party libraries. This follows the same pattern used for UIViewOperationQueue in D93069524. Also clean up direct usages: - UIViewOperationQueue: remove NativeViewHierarchyManager constructor parameter and getNativeViewHierarchyManager() method - UIImplementation: stop creating NativeViewHierarchyManager instance - ReactAndroid.api: update API surface to reflect constructor change UIBlock.kt is left unchanged — its execute(NativeViewHierarchyManager) signature is kept for backward compatibility with third-party libraries (expo-modules-core, react-native-maps, gesture-handler, view-shot). Changelog: [Android][Removed] - Stub out NativeViewHierarchyManager (Legacy Architecture) Reviewed By: NickGerleman Differential Revision: D93801180
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Stub out NativeViewHierarchyManager by removing all fields, private methods, and method body implementations while keeping all public method signatures with empty bodies for backward compatibility with third-party libraries. This follows the same pattern used for UIViewOperationQueue in D93069524. Also clean up direct usages: - UIViewOperationQueue: remove NativeViewHierarchyManager constructor parameter and getNativeViewHierarchyManager() method - UIImplementation: stop creating NativeViewHierarchyManager instance - ReactAndroid.api: update API surface to reflect constructor change UIBlock.kt is left unchanged — its execute(NativeViewHierarchyManager) signature is kept for backward compatibility with third-party libraries (expo-modules-core, react-native-maps, gesture-handler, view-shot). Changelog: [Android][Removed] - Stub out NativeViewHierarchyManager (Legacy Architecture) Reviewed By: NickGerleman Differential Revision: D93801180
Collaborator
|
This pull request was successfully merged by @mdvacca in c2156a8 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in c2156a8. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55758 Stub out NativeViewHierarchyManager by removing all fields, private methods, and method body implementations while keeping all public method signatures with empty bodies for backward compatibility with third-party libraries. This follows the same pattern used for UIViewOperationQueue in D93069524. Also clean up direct usages: - UIViewOperationQueue: remove NativeViewHierarchyManager constructor parameter and getNativeViewHierarchyManager() method - UIImplementation: stop creating NativeViewHierarchyManager instance - ReactAndroid.api: update API surface to reflect constructor change UIBlock.kt is left unchanged — its execute(NativeViewHierarchyManager) signature is kept for backward compatibility with third-party libraries (expo-modules-core, react-native-maps, gesture-handler, view-shot). Changelog: [Android][Removed] - Stub out NativeViewHierarchyManager (Legacy Architecture) Reviewed By: NickGerleman Differential Revision: D93801180 fbshipit-source-id: 20b2e47c338b8beb4f78593045f49b1a52efa966
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Stub out NativeViewHierarchyManager by removing all fields, private methods, and method body implementations while keeping all public method signatures with empty bodies for backward compatibility with third-party libraries. This follows the same pattern used for UIViewOperationQueue in D93069524.
Also clean up direct usages:
UIBlock.kt is left unchanged — its execute(NativeViewHierarchyManager) signature is kept for backward compatibility with third-party libraries (expo-modules-core, react-native-maps, gesture-handler, view-shot).
Changelog: [Android][Removed] - Stub out NativeViewHierarchyManager (Legacy Architecture)
Reviewed By: NickGerleman
Differential Revision: D93801180