Stub UIImplementation and clean up usages#55759
Closed
mdvacca wants to merge 2 commits intofacebook:mainfrom
Closed
Stub UIImplementation and clean up usages#55759mdvacca wants to merge 2 commits intofacebook:mainfrom
mdvacca wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Stub out NativeViewHierarchyManager by removing all fields, private methods, and method body implementations while keeping all public method signatures with empty bodies for backward compatibility with third-party libraries. This follows the same pattern used for UIViewOperationQueue in D93069524. Also clean up direct usages: - UIViewOperationQueue: remove NativeViewHierarchyManager constructor parameter and getNativeViewHierarchyManager() method - UIImplementation: stop creating NativeViewHierarchyManager instance - ReactAndroid.api: update API surface to reflect constructor change UIBlock.kt is left unchanged — its execute(NativeViewHierarchyManager) signature is kept for backward compatibility with third-party libraries (expo-modules-core, react-native-maps, gesture-handler, view-shot). Changelog: [Android][Removed] - Stub out NativeViewHierarchyManager (Legacy Architecture) Reviewed By: NickGerleman Differential Revision: D93801180
Summary: Continuing the Legacy Architecture cleanup, this diff stubs out UIImplementation by removing all fields, private methods, and method body implementations while keeping all public/protected method signatures with empty bodies. The primary consumer UIManagerModule is cleaned up to no longer reference UIImplementation — all delegating methods become empty stubs, and getConstantsForViewManager now uses mViewManagerRegistry directly. Same pattern as NativeViewHierarchyManager (D93801180) and UIViewOperationQueue (D93069524). Changes: - UIImplementation.java: Remove all fields and private methods. Both constructors become empty. All public/protected methods retain signatures with empty bodies returning null/0/empty map as appropriate. LayoutUpdateListener interface preserved. - UIManagerModule.java: Remove mUIImplementation field and getUIImplementation() method. All methods that delegated to UIImplementation become empty stubs, retaining only non-UIImplementation logic (event dispatcher teardown, Fabric sendAccessibilityEvent branch, debug logging, ViewUtil.isRootTag for resolveRootTagFromReactTag). - ReactAndroid.api: Remove 5 protected fields from UIImplementation, remove getUIImplementation() from UIManagerModule. Reviewed By: NickGerleman Differential Revision: D93806249
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in fbe15f6. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: changelog: [Android][Breaking] stub UIImplementation class, this class is unused in the new architecture Pull Request resolved: facebook#55759 Continuing the Legacy Architecture cleanup, this diff stubs out UIImplementation by removing all fields, private methods, and method body implementations while keeping all public/protected method signatures with empty bodies. The primary consumer UIManagerModule is cleaned up to no longer reference UIImplementation — all delegating methods become empty stubs, and getConstantsForViewManager now uses mViewManagerRegistry directly. Same pattern as NativeViewHierarchyManager (D93801180) and UIViewOperationQueue (D93069524). Changes: - UIImplementation.java: Remove all fields and private methods. Both constructors become empty. All public/protected methods retain signatures with empty bodies returning null/0/empty map as appropriate. LayoutUpdateListener interface preserved. - UIManagerModule.java: Remove mUIImplementation field and getUIImplementation() method. All methods that delegated to UIImplementation become empty stubs, retaining only non-UIImplementation logic (event dispatcher teardown, Fabric sendAccessibilityEvent branch, debug logging, ViewUtil.isRootTag for resolveRootTagFromReactTag). - ReactAndroid.api: Remove 5 protected fields from UIImplementation, remove getUIImplementation() from UIManagerModule. Reviewed By: NickGerleman Differential Revision: D93806249 fbshipit-source-id: aed59fb824d021733306f9957dfb4c057aae08d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Continuing the Legacy Architecture cleanup, this diff stubs out UIImplementation by removing all fields, private methods, and method body implementations while keeping all public/protected method signatures with empty bodies. The primary consumer UIManagerModule is cleaned up to no longer reference UIImplementation — all delegating methods become empty stubs, and getConstantsForViewManager now uses mViewManagerRegistry directly.
Same pattern as NativeViewHierarchyManager (D93801180) and UIViewOperationQueue (D93069524).
Changes:
Reviewed By: NickGerleman
Differential Revision: D93806249