Add Fantom integration test for TouchableHighlight#55856
Closed
ellemac123 wants to merge 1 commit intofacebook:mainfrom
Closed
Add Fantom integration test for TouchableHighlight#55856ellemac123 wants to merge 1 commit intofacebook:mainfrom
ellemac123 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@ellemac123 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94915558. |
meta-cla
bot
added
the
CLA Signed
Summary: Changelog: [Internal] TouchableHighlight was the only Touchable component without a Fantom integration test. Both TouchableOpacity and TouchableWithoutFeedback already had itests. This adds one for TouchableHighlight to complete the Fantom coverage for the Touchable family. Tests cover: rendering, accessibility props (via accessibilityPropsSuite), style application, activeOpacity, onPress callback, disabled state, children rendering, and ref instance/tagName. Reviewed By: sammy-SC Differential Revision: D94915558
ellemac123
force-pushed
the
export-D94915558
branch
from
de2d030 to
b2a51f9
Compare
Collaborator
|
This pull request was successfully merged by Laura Macaluso in dd6980c When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in dd6980c. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55856 Changelog: [Internal] TouchableHighlight was the only Touchable component without a Fantom integration test. Both TouchableOpacity and TouchableWithoutFeedback already had itests. This adds one for TouchableHighlight to complete the Fantom coverage for the Touchable family. Tests cover: rendering, accessibility props (via accessibilityPropsSuite), style application, activeOpacity, onPress callback, disabled state, children rendering, and ref instance/tagName. Reviewed By: sammy-SC Differential Revision: D94915558 fbshipit-source-id: 5f8ef3039a2f8a4983ee5e26e7f300797f33d61d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
TouchableHighlight was the only Touchable component without a Fantom integration test. Both TouchableOpacity and TouchableWithoutFeedback already had itests. This adds one for TouchableHighlight to complete the Fantom coverage for the Touchable family.
Tests cover: rendering, accessibility props (via accessibilityPropsSuite), style application, activeOpacity, onPress callback, disabled state, children rendering, and ref instance/tagName.
Reviewed By: sammy-SC
Differential Revision: D94915558