Make DevSupportHttpClient internal#55883
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
meta-cla
bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95059038. |
cortinico
force-pushed
the
export-D95059038
branch
from
013f8e3 to
b7cad46
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
force-pushed
the
export-D95059038
branch
from
b7cad46 to
916ea4a
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
force-pushed
the
export-D95059038
branch
from
916ea4a to
449eafd
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: facebook#55883 All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
force-pushed
the
export-D95059038
branch
from
449eafd to
f5546f8
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: facebook#55883 All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
force-pushed
the
export-D95059038
branch
2 times, most recently
from
ea361fb to
b885168
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: facebook#55883 All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
cortinico
force-pushed
the
export-D95059038
branch
from
b885168 to
102e829
Compare
|
This pull request has been merged in 859ae5c. |
Collaborator
|
This pull request was successfully merged by @cortinico in 859ae5c When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55883 All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038 fbshipit-source-id: 7aeb04503ac5eaa538cbb8b4d9352ae97d165ea0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
All 7 callers of DevSupportHttpClient are within ReactAndroid, so
there is no need to expose it as a public API. Make the class and all its members internal.
While this would be considered breaking, I'm planning to pick this into 0.85 to make this change not breaking. This API has just been introduced in 0.85 and I'm fine having it not exposed.
Changelog: [Internal]
Differential Revision: D95059038