Add reset tests for View prop transformations#55893
Closed
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Closed
Add reset tests for View prop transformations#55893sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Conversation
…5891) Summary: `RenderOutput::renderView` merged old cached props with new debug props via `mergeDynamicProps`. Since `getDebugProps()` omits default-valued props, removed props were never cleared from the cache. Also, `renderedViews_.insert()` never overwrote existing entries. Changelog: [Internal] Reviewed By: javache, zeyap Differential Revision: D95055704
Summary: add tests to validate that aria-* props are set back to default correctly when set to undefined Changelog: [Internal] Reviewed By: javache Differential Revision: D95061571
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in a3a8991. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in a3a8991 When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55893 add tests to validate that aria-* props are set back to default correctly when set to undefined Changelog: [Internal] Reviewed By: javache Differential Revision: D95061571 fbshipit-source-id: c035132638fe7223ef544fb422c1a12f57c5fdb6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
add tests to validate that aria-* props are set back to default correctly when set to undefined
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D95061571